Put spaces back in condition rendering
ClosedPublic
Actions

Authored by epriestley on Aug 3 2015, 10:36 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Dec 27, 4:43 AM

	Unknown Object (File)
	Fri, Dec 20, 7:23 PM

	Unknown Object (File)
	Sat, Dec 7, 7:32 AM

	Unknown Object (File)
	Tue, Dec 3, 5:33 PM

	Unknown Object (File)
	Tue, Dec 3, 5:33 PM

	Unknown Object (File)
	Tue, Dec 3, 5:27 PM

	Unknown Object (File)
	Tue, Dec 3, 5:07 PM

	Unknown Object (File)
	Mon, Dec 2, 5:26 PM

View All Files

Subscribers

None

Details

Reviewers

joshuaspence
chad

Maniphest Tasks

T9055: Weird Herald spacing

Commits

Restricted Diffusion Commit
rP05c571794b5d: Put spaces back in condition rendering

Summary

Fixes T9055. I mostly tested with "Always" rules so I missed this.

Test Plan

Screen Shot 2015-08-03 at 3.35.41 PM.png (233×365 px, 21 KB)

Diff Detail

Repository

rP Phabricator

Branch

heraldui1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 7474
Build 7988: [Placeholder Plan] Wait for 30 Seconds
Build 7987: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 33284.Aug 3 2015, 10:36 PM

epriestley retitled this revision from to Put spaces back in condition rendering.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: joshuaspence, chad.

epriestley added a task: T9055: Weird Herald spacing.

Feels a bit icky, but sure.

This revision is now accepted and ready to land.Aug 3 2015, 10:38 PM

Closed by commit rP05c571794b5d: Put spaces back in condition rendering (authored by epriestley, committed by epriestley). · Explain WhyAug 3 2015, 10:49 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

herald/

adapter/

HeraldAdapter.php

2 lines

Diff 33284

View Options

src/applications/herald/adapter/HeraldAdapter.php

Put spaces back in condition renderingClosedPublicActions