Page MenuHomePhabricator

Update Auth for handleRequest
ClosedPublic

Authored by chad on Jul 28 2015, 6:48 PM.
Tags
None
Referenced Files
F19105899: D13748.diff
Sat, Dec 6, 3:45 PM
F19065952: D13748.id33209.diff
Sun, Nov 30, 3:33 AM
F19056669: D13748.id33208.diff
Fri, Nov 28, 8:19 PM
F19044556: D13748.id33262.diff
Thu, Nov 27, 3:41 AM
F19032379: D13748.diff
Tue, Nov 25, 6:25 AM
F18997200: D13748.diff
Thu, Nov 20, 10:39 AM
F18881386: D13748.id.diff
Nov 6 2025, 9:19 PM
F18874992: D13748.diff
Nov 5 2025, 4:28 PM
Subscribers

Details

Summary

Updates Auth app for handleRequest

Test Plan

Tested what I could, Log in, Log out, Change Password, New account, Verify account... but extra eyes very helpful here.

Diff Detail

Repository
rP Phabricator
Branch
auth-process
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7466
Build 7972: [Placeholder Plan] Wait for 30 Seconds
Build 7971: arc lint + arc unit

Event Timeline

chad retitled this revision from to Update Auth for handleRequest.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
src/applications/auth/controller/PhabricatorAuthInviteController.php
11 ↗(On Diff #33208)

maybe this is wrong

src/applications/auth/controller/PhabricatorAuthUnlinkController.php
115

derp

src/applications/auth/controller/PhabricatorEmailLoginController.php
11

derp2

epriestley edited edge metadata.
epriestley added inline comments.
src/applications/auth/controller/PhabricatorAuthInviteController.php
11 ↗(On Diff #33209)

$request->getViewer() and $this->getViewer() do exactly the same thing, but $this->getViewer() is the newer / more-preferred mechanism. It works more consistently in more places.

This revision is now accepted and ready to land.Aug 1 2015, 10:42 PM
chad marked an inline comment as done.
chad edited edge metadata.
  • clean up derps
  • Update to $viewer = $this->getViewer();
This revision was automatically updated to reflect the committed changes.