Page MenuHomePhabricator

Update Auth for handleRequest
ClosedPublic

Authored by chad on Jul 28 2015, 6:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 4, 2:18 PM
Unknown Object (File)
Sat, Jan 4, 2:15 PM
Unknown Object (File)
Wed, Jan 1, 9:53 PM
Unknown Object (File)
Tue, Dec 31, 8:48 AM
Unknown Object (File)
Fri, Dec 27, 5:31 PM
Unknown Object (File)
Dec 14 2024, 5:31 PM
Unknown Object (File)
Dec 6 2024, 4:58 AM
Unknown Object (File)
Dec 5 2024, 7:57 PM
Subscribers

Details

Summary

Updates Auth app for handleRequest

Test Plan

Tested what I could, Log in, Log out, Change Password, New account, Verify account... but extra eyes very helpful here.

Diff Detail

Repository
rP Phabricator
Branch
auth-process
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7466
Build 7972: [Placeholder Plan] Wait for 30 Seconds
Build 7971: arc lint + arc unit

Event Timeline

chad retitled this revision from to Update Auth for handleRequest.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
src/applications/auth/controller/PhabricatorAuthInviteController.php
11 ↗(On Diff #33208)

maybe this is wrong

src/applications/auth/controller/PhabricatorAuthUnlinkController.php
115

derp

src/applications/auth/controller/PhabricatorEmailLoginController.php
11

derp2

epriestley edited edge metadata.
epriestley added inline comments.
src/applications/auth/controller/PhabricatorAuthInviteController.php
11 ↗(On Diff #33209)

$request->getViewer() and $this->getViewer() do exactly the same thing, but $this->getViewer() is the newer / more-preferred mechanism. It works more consistently in more places.

This revision is now accepted and ready to land.Aug 1 2015, 10:42 PM
chad marked an inline comment as done.
chad edited edge metadata.
  • clean up derps
  • Update to $viewer = $this->getViewer();
This revision was automatically updated to reflect the committed changes.