Page MenuHomePhabricator
Differential D13774

Update Pholio for handleRequest
ClosedPublic
Actions

Authored by chad on Aug 1 2015, 7:30 PM.
Tags
None
Referenced Files
F17858346: D13774.diff
Sun, Jul 27, 7:30 PM
Unknown Object (File)
Jun 2 2025, 1:18 AM
Unknown Object (File)
May 30 2025, 8:06 PM
Unknown Object (File)
May 29 2025, 7:08 AM
Unknown Object (File)
May 25 2025, 6:19 AM
Unknown Object (File)
May 8 2025, 8:19 AM
Unknown Object (File)
May 1 2025, 4:18 AM
Unknown Object (File)
Apr 30 2025, 10:53 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T8628: Modernize AphrontControllers to implement handleRequest
Commits
Restricted Diffusion Commit
rPe5bf2ac37389: Update Pholio for handleRequest
Summary

Run through and update Pholio

Test Plan

New Mock, Edit Mock, Inline Comment, Normal Comment, replace mock, view lists.

Diff Detail

Repository
rP Phabricator
Branch
pholio-process
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7465
Build 7970: [Placeholder Plan] Wait for 30 Seconds
Build 7969: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 33252.Aug 1 2015, 7:30 PM
chad retitled this revision from to Update Pholio for handleRequest.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptAug 1 2015, 7:30 PM
epriestley accepted this revision.Aug 1 2015, 10:38 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 1 2015, 10:38 PM
Closed by commit rPe5bf2ac37389: Update Pholio for handleRequest (authored by chad, committed by chad). · Explain WhyAug 1 2015, 10:39 PM
This revision was automatically updated to reflect the committed changes.
joshuaspence added a task: T8628: Modernize AphrontControllers to implement handleRequest.Oct 18 2015, 6:57 AM

Revision Contents
Changeset List

Diff 33252

View Options

src/applications/pholio/controller/PholioImageUploadController.php

Loading...
View Options

src/applications/pholio/controller/PholioInlineController.php

Loading...
View Options

src/applications/pholio/controller/PholioInlineListController.php

Loading...
View Options

src/applications/pholio/controller/PholioMockCommentController.php

Loading...
View Options

src/applications/pholio/controller/PholioMockEditController.php

Loading...
View Options

src/applications/pholio/controller/PholioMockListController.php

Loading...
View Options

src/applications/pholio/controller/PholioMockViewController.php

Loading...
Phabricator · Built by Phacility