Page MenuHomePhabricator

Update Auth for handleRequest
ClosedPublic

Authored by chad on Jul 28 2015, 6:48 PM.
Tags
None
Referenced Files
F14039338: D13748.diff
Mon, Nov 11, 5:18 AM
F14023479: D13748.diff
Thu, Nov 7, 2:14 AM
F13989251: D13748.id33209.diff
Mon, Oct 21, 7:15 PM
F13988254: D13748.id33209.diff
Mon, Oct 21, 2:16 PM
F13982669: D13748.id33208.diff
Oct 20 2024, 1:04 AM
F13982229: D13748.diff
Oct 19 2024, 9:57 PM
F13968935: D13748.id33262.diff
Oct 16 2024, 11:34 PM
F13964348: D13748.id33263.diff
Oct 15 2024, 8:04 PM
Subscribers

Details

Summary

Updates Auth app for handleRequest

Test Plan

Tested what I could, Log in, Log out, Change Password, New account, Verify account... but extra eyes very helpful here.

Diff Detail

Repository
rP Phabricator
Branch
auth-process
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7433
Build 7906: [Placeholder Plan] Wait for 30 Seconds
Build 7905: arc lint + arc unit

Event Timeline

chad retitled this revision from to Update Auth for handleRequest.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
src/applications/auth/controller/PhabricatorAuthInviteController.php
11

maybe this is wrong

src/applications/auth/controller/PhabricatorAuthUnlinkController.php
115

derp

src/applications/auth/controller/PhabricatorEmailLoginController.php
11

derp2

epriestley edited edge metadata.
epriestley added inline comments.
src/applications/auth/controller/PhabricatorAuthInviteController.php
11

$request->getViewer() and $this->getViewer() do exactly the same thing, but $this->getViewer() is the newer / more-preferred mechanism. It works more consistently in more places.

This revision is now accepted and ready to land.Aug 1 2015, 10:42 PM
chad marked an inline comment as done.
chad edited edge metadata.
  • clean up derps
  • Update to $viewer = $this->getViewer();
This revision was automatically updated to reflect the committed changes.