Add MAILTAGs to Badges
ClosedPublic
Actions

Authored by chad on Jul 25 2015, 7:21 PM.

Details

Reviewers

epriestley
eadler

Commits

Restricted Diffusion Commit
rP82edde8876ee: Add MAILTAGs to Badges

Summary

Still doesn't mail yet, but the settings now show up.

Test Plan

View email settings, see Badges options.

Diff Detail

Repository

rP Phabricator

Branch

badge-mailtags

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 7391
Build 7822: [Placeholder Plan] Wait for 30 Seconds
Build 7821: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 33135.Jul 25 2015, 7:21 PM

chad retitled this revision from to Add MAILTAGs to Badges.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJul 25 2015, 7:21 PM

eadler accepted this revision.Jul 25 2015, 7:29 PM

eadler added a reviewer: eadler.

This revision is now accepted and ready to land.Jul 25 2015, 7:29 PM

Fix mail reply handler

chad requested a review of this revision.Jul 25 2015, 8:27 PM

chad edited edge metadata.

epriestley accepted this revision.Jul 25 2015, 8:30 PM

epriestley edited edge metadata.

epriestley added inline comments.

resources/sql/autopatches/20150725.badges.mailkey.2.php
9 ↗	(On Diff #33137)	"package" -> "badge"

This revision is now accepted and ready to land.Jul 25 2015, 8:30 PM

Closed by commit rP82edde8876ee: Add MAILTAGs to Badges (authored by chad, committed by chad). · Explain WhyJul 25 2015, 8:34 PM

This revision was automatically updated to reflect the committed changes.

chad marked an inline comment as done.

Revision Contents
Changeset List

Path

Size

src/

applications/

badges/

editor/

PhabricatorBadgesEditor.php

17 lines

storage/

PhabricatorBadgesTransaction.php

27 lines

Diff 33135

View Options

src/applications/badges/editor/PhabricatorBadgesEditor.php