Page MenuHomePhabricator
Differential D13712

Add MAILTAGs to Badges
ClosedPublic
Actions

Authored by chad on Jul 25 2015, 7:21 PM.
Tags
None
Referenced Files
F14040505: D13712.id33135.diff
Mon, Nov 11, 10:41 AM
F14008885: D13712.diff
Wed, Oct 30, 7:18 AM
F14007341: D13712.diff
Tue, Oct 29, 4:05 AM
F13996802: D13712.id.diff
Thu, Oct 24, 12:02 AM
F13964658: D13712.id33135.diff
Oct 15 2024, 9:13 PM
F13964240: D13712.id33138.diff
Oct 15 2024, 7:57 PM
Unknown Object (File)
Oct 10 2024, 1:20 PM
Unknown Object (File)
Oct 10 2024, 1:20 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
eadler
Commits
Restricted Diffusion Commit
rP82edde8876ee: Add MAILTAGs to Badges
Summary

Still doesn't mail yet, but the settings now show up.

Test Plan

View email settings, see Badges options.

Diff Detail

Repository
rP Phabricator
Branch
badge-mailtags
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7392
Build 7824: [Placeholder Plan] Wait for 30 Seconds
Build 7823: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 33135.Jul 25 2015, 7:21 PM
chad retitled this revision from to Add MAILTAGs to Badges.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJul 25 2015, 7:21 PM
eadler accepted this revision.Jul 25 2015, 7:29 PM
eadler added a reviewer: eadler.
This revision is now accepted and ready to land.Jul 25 2015, 7:29 PM
chad updated this revision to Diff 33137.Jul 25 2015, 8:25 PM
chad edited edge metadata.
  • Fix mail reply handler
chad requested a review of this revision.Jul 25 2015, 8:27 PM
chad edited edge metadata.
epriestley accepted this revision.Jul 25 2015, 8:30 PM
epriestley edited edge metadata.
epriestley added inline comments.
resources/sql/autopatches/20150725.badges.mailkey.2.php
9

"package" -> "badge"

This revision is now accepted and ready to land.Jul 25 2015, 8:30 PM
Closed by commit rP82edde8876ee: Add MAILTAGs to Badges (authored by chad, committed by chad). · Explain WhyJul 25 2015, 8:34 PM
This revision was automatically updated to reflect the committed changes.
chad marked an inline comment as done.

Revision Contents
Changeset List

Diff 33137

View Options

resources/sql/autopatches/20150725.badges.mailkey.1.sql

Loading...
View Options

resources/sql/autopatches/20150725.badges.mailkey.2.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/badges/editor/PhabricatorBadgesEditor.php

Loading...
View Options

src/applications/badges/mail/PhabricatorBadgesMailReceiver.php

Loading...
View Options

src/applications/badges/mail/PhabricatorBadgesReplyHandler.php

Loading...
View Options

src/applications/badges/storage/PhabricatorBadgesBadge.php

Loading...
View Options

src/applications/badges/storage/PhabricatorBadgesTransaction.php

Loading...
Phabricator · Built by Phacility