Page MenuHomePhabricator
Differential D13706

Modularize Maniphest Herald "Assign Task" action
ClosedPublic
Actions

Authored by epriestley on Jul 24 2015, 8:03 PM.
Tags
None
Referenced Files
F14493764: D13706.diff
Fri, Jan 3, 3:37 AM
Unknown Object (File)
Fri, Dec 27, 2:51 PM
Unknown Object (File)
Fri, Dec 20, 12:09 PM
Unknown Object (File)
Sat, Dec 14, 5:38 PM
Unknown Object (File)
Fri, Dec 13, 6:07 PM
Unknown Object (File)
Mon, Dec 9, 11:37 AM
Unknown Object (File)
Thu, Dec 5, 12:44 PM
Unknown Object (File)
Thu, Dec 5, 12:02 PM
View All Files
Subscribers
epriestley
joshuaspence
Tokens
"Orange Medal" token, awarded by joshuaspence.

Details

Reviewers
btrahan
Maniphest Tasks
T8726: Modularize Herald fields and actions
Commits
Restricted Diffusion Commit
rP8d8ee18ce0fd: Modularize Maniphest Herald "Assign Task" action
Summary

Ref T8726. No surprises here.

Test Plan
  • Created rules using this action.
  • Applied migration.
  • Verified rules still work.

Screen Shot 2015-07-24 at 12.58.04 PM.png (302×513 px, 41 KB)

Diff Detail

Repository
rP Phabricator
Branch
heraldx7
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/maniphest/herald/ManiphestTaskAssignOtherHeraldAction.php:25XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 7384
Build 7808: [Placeholder Plan] Wait for 30 Seconds
Build 7807: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 33124.Jul 24 2015, 8:03 PM
epriestley retitled this revision from to Modularize Maniphest Herald "Assign Task" action.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T8726: Modularize Herald fields and actions.
Herald added a subscriber: epriestley. · View Herald TranscriptJul 24 2015, 8:03 PM
btrahan accepted this revision.Jul 25 2015, 12:52 AM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jul 25 2015, 12:52 AM
joshuaspence awarded a token.Jul 25 2015, 1:23 AM
joshuaspence added a subscriber: joshuaspence.
Closed by commit rP8d8ee18ce0fd: Modularize Maniphest Herald "Assign Task" action (authored by epriestley, committed by epriestley). · Explain WhyAug 3 2015, 9:52 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 33124

View Options

resources/sql/autopatches/20150724.herald.4.sql

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/herald/action/HeraldApplicationActionGroup.php

Loading...
View Options

src/applications/herald/adapter/HeraldAdapter.php

Loading...
View Options

src/applications/herald/controller/HeraldTranscriptController.php

Loading...
View Options

src/applications/maniphest/editor/ManiphestTransactionEditor.php

Loading...
View Options

src/applications/maniphest/herald/HeraldManiphestTaskAdapter.php

Loading...
View Options

src/applications/maniphest/herald/ManiphestTaskAssignHeraldAction.php

Loading...
View Options

src/applications/maniphest/herald/ManiphestTaskAssignOtherHeraldAction.php

Loading...
View Options

src/applications/maniphest/herald/ManiphestTaskAssignSelfHeraldAction.php

Loading...
Phabricator · Built by Phacility