Differential D13699

Make "Add Subscribers" and "Remove Subscribers" Herald actions modular
ClosedPublic
Actions

Authored by epriestley on Jul 24 2015, 2:54 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T8726: Modularize Herald fields and actions

Commits

Restricted Diffusion Commit
rP8ae08a3de70b: Make "Add Subscribers" and "Remove Subscribers" Herald actions modular

Summary

Ref T8726. Converts these actions to be modular. No real surprises in this change.

Test Plan

Wrote some rules.
Migrated them forward.
Used a bunch of these rules.

Diff Detail

Repository

rP Phabricator

Branch

heraldx4

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 7376
Build 7792: [Placeholder Plan] Wait for 30 Seconds
Build 7791: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 33111.Jul 24 2015, 2:54 PM

epriestley retitled this revision from to Make "Add Subscribers" and "Remove Subscribers" Herald actions modular.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T8726: Modularize Herald fields and actions.

Herald added a subscriber: epriestley. · View Herald TranscriptJul 24 2015, 2:54 PM

btrahan accepted this revision.Jul 24 2015, 5:42 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Jul 24 2015, 5:42 PM

joshuaspence added a subscriber: joshuaspence.Jul 25 2015, 11:28 PM

Closed by commit rP8ae08a3de70b: Make "Add Subscribers" and "Remove Subscribers" Herald actions modular (authored by epriestley, committed by epriestley). · Explain WhyAug 3 2015, 9:52 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20150724.herald.1.sql

27 lines

src/

__phutil_library_map__.php

10 lines

applications/

differential/

herald/

HeraldDifferentialRevisionAdapter.php

4 lines

diffusion/

herald/

HeraldCommitAdapter.php

4 lines

herald/

action/

HeraldAction.php

24 lines

adapter/

HeraldAdapter.php

144 lines

maniphest/

herald/

HeraldManiphestTaskAdapter.php

4 lines

pholio/

herald/

HeraldPholioMockAdapter.php

19 lines

phriction/

herald/

PhrictionDocumentHeraldAdapter.php

4 lines

subscriptions/

herald/

PhabricatorSubscriptionsAddSelfHeraldAction.php

37 lines

PhabricatorSubscriptionsAddSubscribersHeraldAction.php

40 lines

PhabricatorSubscriptionsHeraldAction.php

235 lines

PhabricatorSubscriptionsRemoveSelfHeraldAction.php

37 lines

PhabricatorSubscriptionsRemoveSubscribersHeraldAction.php

40 lines

infrastructure/

internationalization/

translation/

PhabricatorUSEnglishTranslation.php

33 lines

Diff 33111

View Options

resources/sql/autopatches/20150724.herald.1.sql

View Options

src/__phutil_library_map__.php

View Options

src/applications/differential/herald/HeraldDifferentialRevisionAdapter.php

View Options

src/applications/diffusion/herald/HeraldCommitAdapter.php

View Options

src/applications/herald/action/HeraldAction.php

View Options

src/applications/herald/adapter/HeraldAdapter.php

View Options

src/applications/maniphest/herald/HeraldManiphestTaskAdapter.php

View Options

src/applications/pholio/herald/HeraldPholioMockAdapter.php

View Options

src/applications/phriction/herald/PhrictionDocumentHeraldAdapter.php

View Options

src/applications/subscriptions/herald/PhabricatorSubscriptionsAddSelfHeraldAction.php

View Options

src/applications/subscriptions/herald/PhabricatorSubscriptionsAddSubscribersHeraldAction.php

View Options

src/applications/subscriptions/herald/PhabricatorSubscriptionsHeraldAction.php

View Options

src/applications/subscriptions/herald/PhabricatorSubscriptionsRemoveSelfHeraldAction.php

View Options

src/applications/subscriptions/herald/PhabricatorSubscriptionsRemoveSubscribersHeraldAction.php

View Options

src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php

Make "Add Subscribers" and "Remove Subscribers" Herald actions modularClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 33111

resources/sql/autopatches/20150724.herald.1.sql

src/__phutil_library_map__.php

src/applications/differential/herald/HeraldDifferentialRevisionAdapter.php

src/applications/diffusion/herald/HeraldCommitAdapter.php

src/applications/herald/action/HeraldAction.php

src/applications/herald/adapter/HeraldAdapter.php

src/applications/maniphest/herald/HeraldManiphestTaskAdapter.php

src/applications/pholio/herald/HeraldPholioMockAdapter.php

src/applications/phriction/herald/PhrictionDocumentHeraldAdapter.php

src/applications/subscriptions/herald/PhabricatorSubscriptionsAddSelfHeraldAction.php

src/applications/subscriptions/herald/PhabricatorSubscriptionsAddSubscribersHeraldAction.php

src/applications/subscriptions/herald/PhabricatorSubscriptionsHeraldAction.php

src/applications/subscriptions/herald/PhabricatorSubscriptionsRemoveSelfHeraldAction.php

src/applications/subscriptions/herald/PhabricatorSubscriptionsRemoveSubscribersHeraldAction.php

src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php

Make "Add Subscribers" and "Remove Subscribers" Herald actions modular
ClosedPublic
Actions

Revision Contents
Changeset List