Page MenuHomePhabricator
Differential D13698

Add $projectRoot to PytestTestEngine
ClosedPublic
Actions

Authored by • lbrabec on Jul 24 2015, 7:41 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 17, 8:15 PM
Unknown Object (File)
Sun, Jan 12, 5:51 AM
Unknown Object (File)
Sat, Jan 11, 8:32 AM
Unknown Object (File)
Tue, Dec 31, 10:43 PM
Unknown Object (File)
Fri, Dec 27, 5:39 PM
Unknown Object (File)
Dec 17 2024, 10:22 AM
Unknown Object (File)
Dec 15 2024, 12:43 AM
Unknown Object (File)
Dec 9 2024, 1:49 AM
View All Files
Subscribers
epriestley
Korvin
kparal

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T8912: Unable to run `arc unit`, PytestTestEngine throws exception
Commits
rARC5fcf7b5a3b9e: Add $projectRoot to PytestTestEngine
Required Signatures
L28 Phacility Individual Contributor License Agreement
Summary

Fixes T8912. Property $project_root was missing in PytestTestEngine class, resulting in
broken py.test wrapper. Also renaming the property so the linter is happy.

Test Plan

arc unit --everything

Diff Detail

Repository
rARC Arcanist
Branch
fix/pytestwrapper
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 7375
Build 7790: [Placeholder Plan] Wait for 30 Seconds
Build 7789: arc lint + arc unit

Unit TestsFailed
View All

TimeTest
10 msPhpunitTestEngineTestCase::Unknown Unit Message ("")
94 msArcanistLibraryTestCase::Unknown Unit Message ("")
46 msArcanistLibraryTestCase::Unknown Unit Message ("")
1 msArcanistLibraryTestCase::Unknown Unit Message ("")
0 msPhutilUnitTestEngineTestCase::Unknown Unit Message ("")
View Full Test Results (1 Failed · 8 Passed)

Event Timeline

• lbrabec updated this revision to Diff 33109.Jul 24 2015, 7:41 AM
• lbrabec retitled this revision from to Add $projectRoot to PytestTestEngine.
• lbrabec updated this object.
• lbrabec edited the test plan for this revision. (Show Details)
• lbrabec added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 24 2015, 7:41 AM
Herald added a required legal document: L28 Phacility Individual Contributor License Agreement. · View Herald Transcript
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
• lbrabec added a task: T8912: Unable to run `arc unit`, PytestTestEngine throws exception.Jul 24 2015, 7:42 AM
kparal added a subscriber: kparal.Jul 24 2015, 9:27 AM
epriestley accepted this revision.Jul 24 2015, 12:11 PM
epriestley edited edge metadata.

Thanks!

This revision is now accepted and ready to land.Jul 24 2015, 12:11 PM
epriestley updated this object.Jul 24 2015, 12:11 PM
epriestley edited edge metadata.
Closed by commit rARC5fcf7b5a3b9e: Add $projectRoot to PytestTestEngine (authored by Lukas Sparrow <lukas.sparrow@gmail.com>, committed by epriestley). · Explain WhyJul 24 2015, 12:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
unit/
engine/
8 lines

Diff 33109

View Options

src/unit/engine/PytestTestEngine.php

Loading...
Phabricator · Built by Phacility