Page MenuHomePhabricator

Unable to run `arc unit`, PytestTestEngine throws exception
Closed, ResolvedPublic


Running arc unit with PytestTestEngine set in .arcconfig ends with exception:

(DomainException) Attempt to write to undeclared property PytestTestEngine::project_root. at [<phutil>/src/object/Phobject.php:30]

I was able to fix this by adding a property to class:

--- PytestTestEngineOrig.php	2015-07-21 12:10:21.010315159 +0200
+++ PytestTestEngine.php	2015-07-21 12:10:40.609450176 +0200
@@ -5,6 +5,8 @@
 final class PytestTestEngine extends ArcanistUnitTestEngine {
+  private $project_root;
   public function run() {
     $working_copy = $this->getWorkingCopy();
     $this->project_root = $working_copy->getProjectRoot();

Revisions and Commits

Event Timeline

lbrabec raised the priority of this task from to Needs Triage.
lbrabec updated the task description. (Show Details)
lbrabec added a project: Arcanist.
lbrabec added subscribers: lbrabec, kparal, tflink.

Happy to accept a diff for this whenever anyone gets around to it.

epriestley triaged this task as Normal priority.Jul 23 2015, 8:30 PM

We're not familiar with the code base, so we weren't sure whether the diff in the description was enough or there was something more to it. It sounds like it is not, so @lbrabec will try to submit a diff right away.