Improve strictness around `setLine()` types in ArcanistLintMessage
ClosedPublic
Actions

Authored by epriestley on Jul 23 2015, 8:17 PM.

Details

Reviewers

btrahan
chad

Maniphest Tasks

T8921: arc diff failing due to "invalid type" error

Commits

rARCbd1da9da6c67: Improve strictness around `setLine()` types in ArcanistLintMessage

Summary

Fixes T8921. Harbormaster is strict about types it accepts, but ArcanistLintMessage is more liberal. Push the strictness barrier down to the linter level, while maintaining reasonable flexibility in the API.

Test Plan

arc unit --everything

Diff Detail

Repository

rARC Arcanist

Branch

lineint

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 7371
Build 7782: [Placeholder Plan] Wait for 30 Seconds
Build 7781: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 33101.Jul 23 2015, 8:17 PM

epriestley retitled this revision from to Improve strictness around `setLine()` types in ArcanistLintMessage.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: btrahan, chad.

epriestley added a task: T8921: arc diff failing due to "invalid type" error.

Herald added a subscriber: epriestley. · View Herald TranscriptJul 23 2015, 8:17 PM

chad accepted this revision.Jul 23 2015, 8:19 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jul 23 2015, 8:19 PM

Closed by commit rARCbd1da9da6c67: Improve strictness around `setLine()` types in ArcanistLintMessage (authored by epriestley, committed by epriestley). · Explain WhyJul 23 2015, 8:19 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in D13737: Also coerce "char" for lint messages.Jul 27 2015, 4:41 PM

epriestley mentioned this in rARCe5946ed1a5fa: Also coerce "char" for lint messages.Jul 28 2015, 11:31 PM

Revision Contents
Changeset List

Path

Size

src/

lint/

ArcanistLintMessage.php

17 lines

Diff 33101

View Options

src/lint/ArcanistLintMessage.php

Improve strictness around `setLine()` types in ArcanistLintMessageClosedPublicActions