Paths

Table of Contentst

Differential D13684

Fix checkstyle severities
ClosedPublic
Actions

Authored by joshuaspence on Jul 22 2015, 11:11 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC5e4f9a2bf9d2: Fix checkstyle severities

Summary

"Advice" is not a valid severity for Checkstyle... valid severities are ignore, info, warning and error.

Test Plan

Read the documentation.

Diff Detail

Repository

rARC Arcanist

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 7357
Build 7754: [Placeholder Plan] Wait for 30 Seconds
Build 7753: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 33081.Jul 22 2015, 11:11 PM

joshuaspence retitled this revision from to Fix checkstyle severities.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 22 2015, 11:11 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

epriestley accepted this revision.Jul 22 2015, 11:11 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jul 22 2015, 11:11 PM

Closed by commit rARC5e4f9a2bf9d2: Fix checkstyle severities (authored by joshuaspence, committed by joshuaspence). · Explain WhyJul 22 2015, 11:14 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

src/

lint/

renderer/

ArcanistCheckstyleXMLLintRenderer.php

15 lines

Diff 33081

View Options

src/lint/renderer/ArcanistCheckstyleXMLLintRenderer.php

Fix checkstyle severitiesClosedPublicActions