Page MenuHomePhabricator
Differential D13684

Fix checkstyle severities
ClosedPublic
Actions

Authored by joshuaspence on Jul 22 2015, 11:11 PM.
Tags
None
Referenced Files
F15539215: D13684.id33083.diff
Fri, Apr 25, 12:11 AM
F15535112: D13684.diff
Thu, Apr 24, 3:37 AM
F15523429: D13684.diff
Mon, Apr 21, 1:23 AM
F15519506: D13684.id33083.diff
Sat, Apr 19, 11:35 PM
F15519505: D13684.id.diff
Sat, Apr 19, 11:35 PM
F15518834: D13684.id33081.diff
Sat, Apr 19, 5:21 PM
F15517119: D13684.id33081.diff
Sat, Apr 19, 12:39 AM
F15510627: D13684.id33083.diff
Wed, Apr 16, 8:28 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARC5e4f9a2bf9d2: Fix checkstyle severities
Summary

"Advice" is not a valid severity for Checkstyle... valid severities are ignore, info, warning and error.

Test Plan

Read the documentation.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7357
Build 7754: [Placeholder Plan] Wait for 30 Seconds
Build 7753: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 33081.Jul 22 2015, 11:11 PM
joshuaspence retitled this revision from to Fix checkstyle severities.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 22 2015, 11:11 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
epriestley accepted this revision.Jul 22 2015, 11:11 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 22 2015, 11:11 PM
Closed by commit rARC5e4f9a2bf9d2: Fix checkstyle severities (authored by joshuaspence, committed by joshuaspence). · Explain WhyJul 22 2015, 11:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
src/
lint/
renderer/
15 lines5%
Loading...

Diff 33081

View Options

src/lint/renderer/ArcanistCheckstyleXMLLintRenderer.php

Loading...
Phabricator · Built by Phacility