Page MenuHomePhabricator
Differential D13677

Modernize Phame process handlers
ClosedPublic
Actions

Authored by chad on Jul 22 2015, 5:04 PM.
Tags
None
Referenced Files
F13158787: D13677.diff
Sun, May 5, 9:41 PM
Unknown Object (File)
Fri, May 3, 8:01 PM
Unknown Object (File)
Fri, May 3, 3:13 AM
Unknown Object (File)
Wed, May 1, 5:59 PM
Unknown Object (File)
Mon, Apr 29, 2:41 PM
Unknown Object (File)
Wed, Apr 24, 10:44 PM
Unknown Object (File)
Mon, Apr 22, 8:25 AM
Unknown Object (File)
Mon, Apr 22, 8:25 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Maniphest Tasks
T8628: Modernize AphrontControllers to implement handleRequest
Commits
Restricted Diffusion Commit
rP1643685e7216: Modernize Phame process handlers
Summary

Converts Phame to use handleRequest where appropriate.

Test Plan

Write some blog posts, publish, edit, view.

Diff Detail

Repository
rP Phabricator
Branch
phame-update-6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7347
Build 7734: [Placeholder Plan] Wait for 30 Seconds
Build 7733: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 33061.Jul 22 2015, 5:04 PM
chad retitled this revision from to Modernize Phame process handlers.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJul 22 2015, 5:04 PM
chad added a task: T8628: Modernize AphrontControllers to implement handleRequest.Jul 22 2015, 7:48 PM
epriestley accepted this revision.Jul 22 2015, 8:21 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 22 2015, 8:21 PM
Closed by commit rP1643685e7216: Modernize Phame process handlers (authored by chad, committed by chad). · Explain WhyJul 22 2015, 8:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 33061

View Options

src/applications/phame/controller/post/PhamePostFramedController.php

Loading...
View Options

src/applications/phame/controller/post/PhamePostListController.php

Loading...
View Options

src/applications/phame/controller/post/PhamePostNotLiveController.php

Loading...
View Options

src/applications/phame/controller/post/PhamePostPublishController.php

Loading...
View Options

src/applications/phame/controller/post/PhamePostUnpublishController.php

Loading...
Phabricator · Built by Phacility