Page MenuHomePhabricator
Differential D13614

Further modularize Herald values
ClosedPublic
Actions

Authored by epriestley on Jul 9 2015, 4:33 PM.
Tags
None
Referenced Files
F14449102: D13614.diff
Thu, Dec 26, 7:46 PM
F14448410: D13614.id32896.diff
Thu, Dec 26, 4:55 PM
F14447914: D13614.id32972.diff
Thu, Dec 26, 2:52 PM
Unknown Object (File)
Sat, Dec 21, 2:02 AM
Unknown Object (File)
Fri, Dec 20, 12:09 PM
Unknown Object (File)
Thu, Dec 19, 4:56 PM
Unknown Object (File)
Sun, Dec 8, 7:05 AM
Unknown Object (File)
Tue, Dec 3, 7:19 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T8726: Modularize Herald fields and actions
Commits
Restricted Diffusion Commit
rPed3dfd491f17: Further modularize Herald values
Summary

Ref T8726. Modularize action values. Fully modularize "text", "none" and "select" controls. Only tokenizers remain.

Test Plan
  • Used all affected value types in UI.
  • Reviewed rules using new modular rendering, saw sensible output.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 32896.Jul 9 2015, 4:33 PM
epriestley retitled this revision from to Further modularize Herald values.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T8726: Modularize Herald fields and actions.
Herald added a subscriber: epriestley. · View Herald TranscriptJul 9 2015, 4:33 PM
btrahan accepted this revision.Jul 16 2015, 8:42 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jul 16 2015, 8:42 PM
Closed by commit rPed3dfd491f17: Further modularize Herald values (authored by epriestley, committed by epriestley). · Explain WhyJul 16 2015, 9:12 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
22 lines
src/
applications/
diffusion/
herald/
22 lines
11 lines
3 lines
herald/
adapter/
16 lines
controller/
35 lines
field/
6 lines
value/
4 lines
1 line
5 lines
5 lines
maniphest/
herald/
1 line
1 line
webroot/
rsrc/
js/
application/
herald/
13 lines

Diff 32972

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionPreCommitRefChangeHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionPreCommitRefTypeHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/HeraldPreCommitRefAdapter.php

Loading...
View Options

src/applications/herald/adapter/HeraldAdapter.php

Loading...
View Options

src/applications/herald/controller/HeraldRuleController.php

Loading...
View Options

src/applications/herald/field/HeraldField.php

Loading...
View Options

src/applications/herald/value/HeraldEmptyFieldValue.php

Loading...
View Options

src/applications/herald/value/HeraldFieldValue.php

Loading...
View Options

src/applications/herald/value/HeraldSelectFieldValue.php

Loading...
View Options

src/applications/herald/value/HeraldTextFieldValue.php

Loading...
View Options

src/applications/maniphest/herald/ManiphestTaskPriorityHeraldField.php

Loading...
View Options

src/applications/maniphest/herald/ManiphestTaskStatusHeraldField.php

Loading...
View Options

webroot/rsrc/js/application/herald/HeraldRuleEditor.js

Loading...
Phabricator · Built by Phacility