Page MenuHomePhabricator

Further modularize Herald values
ClosedPublic

Authored by epriestley on Jul 9 2015, 4:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 3, 7:19 AM
Unknown Object (File)
Thu, Nov 28, 3:27 PM
Unknown Object (File)
Oct 24 2024, 10:45 PM
Unknown Object (File)
Oct 18 2024, 2:31 PM
Unknown Object (File)
Oct 15 2024, 12:42 PM
Unknown Object (File)
Sep 12 2024, 7:49 AM
Unknown Object (File)
Sep 5 2024, 3:00 PM
Unknown Object (File)
Aug 31 2024, 5:11 PM
Subscribers

Details

Summary

Ref T8726. Modularize action values. Fully modularize "text", "none" and "select" controls. Only tokenizers remain.

Test Plan
  • Used all affected value types in UI.
  • Reviewed rules using new modular rendering, saw sensible output.

Diff Detail

Repository
rP Phabricator
Branch
herald3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7231
Build 7504: [Placeholder Plan] Wait for 30 Seconds
Build 7503: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Further modularize Herald values.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jul 16 2015, 8:42 PM
This revision was automatically updated to reflect the committed changes.