Page MenuHomePhabricator

Fix unitialized variable in ArcanistPhpunitTestResultParser
ClosedPublic

Authored by duraseb on Jul 16 2015, 4:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 7, 5:01 AM
Unknown Object (File)
Fri, May 3, 2:22 AM
Unknown Object (File)
Mon, Apr 29, 1:47 PM
Unknown Object (File)
Wed, Apr 24, 9:57 PM
Unknown Object (File)
Sun, Apr 21, 3:54 PM
Unknown Object (File)
Apr 17 2024, 2:58 PM
Unknown Object (File)
Apr 11 2024, 7:10 AM
Unknown Object (File)
Apr 9 2024, 3:51 AM

Details

Summary

This is to fix arc unit when running a test file with no test results (e.g. skipped)

EXCEPTION: (RuntimeException) Undefined variable: last_test_finished at [<phutil>/src/error/PhutilErrorHandler.php:210]
arcanist(head=master, ref.master=d54cb072facd), deviantart(), phutil(head=master, ref.master=75f675747648)
  #0 PhutilErrorHandler::handleError(integer, string, string, integer, array) called at [<arcanist>/src/unit/parser/ArcanistPhpunitTestResultParser.php:95]
  #1 ArcanistPhpunitTestResultParser::parseTestResults(string, string) called at [<deviantart>/unit/DaUnitEngine.php:150]
  #2 DaUnitEngine::parseTestResults(string, TempFile, string, string) called at [<deviantart>/unit/DaUnitEngine.php:82]
  #3 DaUnitEngine::run() called at [<arcanist>/src/workflow/ArcanistUnitWorkflow.php:186]
  #4 ArcanistUnitWorkflow::run() called at [<arcanist>/scripts/arcanist.php:382]
Test Plan

Create a test file with skipped tests. Run arc unit. Make sure the exception is not thrown.

Diff Detail

Repository
rARC Arcanist
Branch
private/PHP-Linter-fix
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7290
Build 7619: [Placeholder Plan] Wait for 30 Seconds
Build 7618: arc lint + arc unit

Event Timeline

duraseb retitled this revision from to Fix unitialized variable in ArcanistPhpunitTestResultParser.
duraseb updated this object.
duraseb edited the test plan for this revision. (Show Details)
duraseb added reviewers: epriestley, joshuaspence.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 16 2015, 8:39 PM
This revision was automatically updated to reflect the committed changes.