Paths

Table of Contentst

Differential D13633

Fix brace formatting linter rule
ClosedPublic
Actions

Authored by joshuaspence on Jul 14 2015, 10:29 PM.

Tags

None

Referenced Files

	F15469531: D13633.id32987.diff
	Fri, Apr 4, 2:14 PM

	F15463127: D13633.id.diff
	Tue, Apr 1, 8:37 PM

	F15460367: D13633.diff
	Mon, Mar 31, 10:22 PM

	F15396020: D13633.diff
	Sun, Mar 16, 11:16 AM

	F15373544: D13633.id32945.diff
	Wed, Mar 12, 4:57 PM

	Unknown Object (File)
	Feb 8 2025, 9:25 PM

	Unknown Object (File)
	Feb 8 2025, 9:25 PM

	Unknown Object (File)
	Feb 8 2025, 9:24 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T8847: Brace placement linter rule

Commits

rARC58302432cc5f: Fix brace formatting linter rule

Summary

Fixes T8847.

Test Plan

Ran arc lint on a test file:

<?php

if ($x) {
  echo 'foo';
}else {
  echo 'bar';
}

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 7274
Build 7588: [Placeholder Plan] Wait for 30 Seconds
Build 7587: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	1,587 ms	ArcanistJSHintLinterTestCase::Unknown Unit Message ("")
	797 ms	ArcanistCSSLintLinterTestCase::Unknown Unit Message ("")
	127 ms	ArcanistCSSLintLinterTestCase::Unknown Unit Message ("")
	149 ms	ArcanistChmodLinterTestCase::Unknown Unit Message ("")
	218 ms	ArcanistClosureLinterTestCase::Unknown Unit Message ("")
		View Full Test Results (1 Failed · 50 Passed · 7 Skipped)

Event Timeline

joshuaspence updated this revision to Diff 32945.Jul 14 2015, 10:29 PM

joshuaspence retitled this revision from to Fix brace formatting linter rule.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T8847: Brace placement linter rule.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 14 2015, 10:29 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

epriestley accepted this revision.Jul 15 2015, 5:16 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jul 15 2015, 5:16 PM

Closed by commit rARC58302432cc5f: Fix brace formatting linter rule (authored by joshuaspence, committed by joshuaspence). · Explain WhyJul 17 2015, 6:41 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

src/

lint/

linter/

__tests__/

xhpast/

creative-brace-use.lint-test

5 lines

-

-

xhpast/

rules/

ArcanistBraceFormattingXHPASTLinterRule.php

4 lines

98%

Loading...

Diff 32945

src/lint/linter/tests/xhpast/creative-brace-use.lint-test

Loading...

src/lint/linter/xhpast/rules/ArcanistBraceFormattingXHPASTLinterRule.php

Loading...