Paths

Table of Contentst

Differential D13633

Fix brace formatting linter rule
ClosedPublic
Actions

Authored by joshuaspence on Jul 14 2015, 10:29 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T8847: Brace placement linter rule

Commits

rARC58302432cc5f: Fix brace formatting linter rule

Summary

Fixes T8847.

Test Plan

Ran arc lint on a test file:

<?php

if ($x) {
  echo 'foo';
}else {
  echo 'bar';
}

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 32945.Jul 14 2015, 10:29 PM

joshuaspence retitled this revision from to Fix brace formatting linter rule.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T8847: Brace placement linter rule.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 14 2015, 10:29 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

epriestley accepted this revision.Jul 15 2015, 5:16 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jul 15 2015, 5:16 PM

Closed by commit rARC58302432cc5f: Fix brace formatting linter rule (authored by joshuaspence, committed by joshuaspence). · Explain WhyJul 17 2015, 6:41 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

__tests__/

xhpast/

creative-brace-use.lint-test

5 lines

xhpast/

rules/

ArcanistBraceFormattingXHPASTLinterRule.php

4 lines

Diff 32987

View Options

src/lint/linter/tests/xhpast/creative-brace-use.lint-test

View Options

src/lint/linter/xhpast/rules/ArcanistBraceFormattingXHPASTLinterRule.php

Fix brace formatting linter ruleClosedPublicActions