Page MenuHomePhabricator
Differential D13601

Modularize Herald Diffusion pre-commit content fields
ClosedPublic
Actions

Authored by epriestley on Jul 8 2015, 11:33 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 11, 5:34 AM
Unknown Object (File)
Sun, Apr 7, 6:02 AM
Unknown Object (File)
Fri, Apr 5, 1:54 AM
Unknown Object (File)
Sun, Mar 31, 9:41 PM
Unknown Object (File)
Sat, Mar 30, 6:55 AM
Unknown Object (File)
Sat, Mar 30, 12:01 AM
Unknown Object (File)
Thu, Mar 28, 1:43 PM
Unknown Object (File)
Sun, Mar 24, 1:43 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T8726: Modularize Herald fields and actions
Commits
Restricted Diffusion Commit
rPe8f063de25c1: Modularize Herald Diffusion pre-commit content fields
Summary

Ref T8726. The gruntwork part of this is finally over.

Test Plan
  • Made a huge rule with every field.
  • Applied migration.
  • Verified the rule was still the same.
  • Pushed a bunch of commits and verified transcripts.

Diff Detail

Repository
rP Phabricator
Branch
hmodular14
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7212
Build 7468: [Placeholder Plan] Wait for 30 Seconds
Build 7467: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 32872.Jul 8 2015, 11:33 AM
epriestley retitled this revision from to Modularize Herald Diffusion pre-commit content fields.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T8726: Modularize Herald fields and actions.
Herald added a subscriber: epriestley. · View Herald TranscriptJul 8 2015, 11:33 AM
btrahan accepted this revision.Jul 8 2015, 6:59 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jul 8 2015, 6:59 PM
Closed by commit rPe8f063de25c1: Modularize Herald Diffusion pre-commit content fields (authored by epriestley, committed by epriestley). · Explain WhyJul 8 2015, 7:27 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
sql/
autopatches/
146 lines
src/
44 lines
applications/
diffusion/
herald/
24 lines
30 lines
24 lines
24 lines
30 lines
24 lines
24 lines
24 lines
24 lines
24 lines
17 lines
24 lines
24 lines
24 lines
27 lines
31 lines
24 lines
32 lines
35 lines
30 lines
36 lines
37 lines
119 lines
herald/
adapter/
226 lines

Diff 32872

View Options

resources/sql/autopatches/20150708.herald.3.sql

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionPreCommitContentAffectedFilesHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionPreCommitContentAuthorHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionPreCommitContentAuthorRawHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionPreCommitContentBranchesHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionPreCommitContentCommitterHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionPreCommitContentCommitterRawHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionPreCommitContentDiffContentAddedHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionPreCommitContentDiffContentHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionPreCommitContentDiffContentRemovedHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionPreCommitContentDiffEnormousHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionPreCommitContentHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionPreCommitContentMergeHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionPreCommitContentMessageHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionPreCommitContentPusherHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionPreCommitContentPusherIsCommitterHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionPreCommitContentPusherProjectsHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionPreCommitContentRepositoryHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionPreCommitContentRepositoryProjectsHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionPreCommitContentRevisionAcceptedHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionPreCommitContentRevisionHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionPreCommitContentRevisionReviewersHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionPreCommitContentRevisionSubscribersHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/HeraldPreCommitContentAdapter.php

Loading...
View Options

src/applications/herald/adapter/HeraldAdapter.php

Loading...
Phabricator · Built by Phacility