Page MenuHomePhabricator

Modularize all Herald pre-commit ref fields
ClosedPublic

Authored by epriestley on Jul 8 2015, 10:40 AM.
Tags
None
Referenced Files
F15486694: D13600.diff
Thu, Apr 10, 8:51 AM
F15442203: D13600.id32870.diff
Wed, Mar 26, 10:09 PM
F15441382: D13600.diff
Wed, Mar 26, 5:54 PM
F15426967: D13600.diff
Mar 23 2025, 11:55 AM
F15410881: D13600.id32868.diff
Mar 19 2025, 8:38 AM
F15394785: D13600.id.diff
Mar 16 2025, 1:10 AM
F15393618: D13600.id32868.diff
Mar 15 2025, 10:47 PM
F15391931: D13600.id32869.diff
Mar 15 2025, 12:24 PM
Subscribers

Details

Summary

Ref T8726. Just (pre-commit content) one more left.

Test Plan
  • Created a big rule with every field.
  • Migrated it.
  • Verified the rule was still the same.
  • Pushed a bunch of changes and reviewed the transcripts.

Diff Detail

Repository
rP Phabricator
Branch
hmodular13
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7210
Build 7464: [Placeholder Plan] Wait for 30 Seconds
Build 7463: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Modularize all Herald pre-commit ref fields.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
  • Also handle special rendering of "Change" rule.
btrahan edited edge metadata.
btrahan added inline comments.
src/applications/herald/adapter/HeraldAdapter.php
1215–1222

nice

This revision is now accepted and ready to land.Jul 8 2015, 7:00 PM
This revision was automatically updated to reflect the committed changes.