Page MenuHomePhabricator

Modularize all Herald pre-commit ref fields
ClosedPublic

Authored by epriestley on Jul 8 2015, 10:40 AM.
Tags
None
Referenced Files
F18966605: D13600.diff
Fri, Nov 14, 7:19 PM
F18803716: D13600.diff
Sat, Oct 18, 3:10 AM
F18749200: D13600.id32870.diff
Oct 4 2025, 2:50 AM
F18709204: D13600.id32869.diff
Sep 28 2025, 11:48 PM
F18621408: D13600.diff
Sep 15 2025, 8:10 AM
F18601004: D13600.id32880.diff
Sep 13 2025, 11:16 AM
F18591334: D13600.diff
Sep 12 2025, 8:57 AM
F18506218: D13600.id.diff
Sep 5 2025, 1:16 AM
Subscribers

Details

Summary

Ref T8726. Just (pre-commit content) one more left.

Test Plan
  • Created a big rule with every field.
  • Migrated it.
  • Verified the rule was still the same.
  • Pushed a bunch of changes and reviewed the transcripts.

Diff Detail

Repository
rP Phabricator
Branch
hmodular13
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7208
Build 7460: [Placeholder Plan] Wait for 30 Seconds
Build 7459: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Modularize all Herald pre-commit ref fields.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
  • Also handle special rendering of "Change" rule.
btrahan edited edge metadata.
btrahan added inline comments.
src/applications/herald/adapter/HeraldAdapter.php
1215–1222 ↗(On Diff #32870)

nice

This revision is now accepted and ready to land.Jul 8 2015, 7:00 PM
This revision was automatically updated to reflect the committed changes.