Page MenuHomePhabricator

Modularize all Herald pre-commit ref fields
ClosedPublic

Authored by epriestley on Jul 8 2015, 10:40 AM.
Tags
None
Referenced Files
F15299637: D13600.id32870.diff
Wed, Mar 5, 3:42 PM
F15283061: D13600.id32868.diff
Tue, Mar 4, 5:00 AM
Unknown Object (File)
Thu, Feb 27, 5:08 AM
Unknown Object (File)
Tue, Feb 25, 1:10 AM
Unknown Object (File)
Wed, Feb 19, 8:10 PM
Unknown Object (File)
Sat, Feb 8, 8:54 PM
Unknown Object (File)
Sat, Feb 8, 8:53 PM
Unknown Object (File)
Sat, Feb 8, 8:53 PM
Subscribers

Details

Summary

Ref T8726. Just (pre-commit content) one more left.

Test Plan
  • Created a big rule with every field.
  • Migrated it.
  • Verified the rule was still the same.
  • Pushed a bunch of changes and reviewed the transcripts.

Diff Detail

Repository
rP Phabricator
Branch
hmodular13
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7209
Build 7462: [Placeholder Plan] Wait for 30 Seconds
Build 7461: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Modularize all Herald pre-commit ref fields.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
  • Also handle special rendering of "Change" rule.
btrahan edited edge metadata.
btrahan added inline comments.
src/applications/herald/adapter/HeraldAdapter.php
1215–1225

nice

This revision is now accepted and ready to land.Jul 8 2015, 7:00 PM
This revision was automatically updated to reflect the committed changes.