Page MenuHomePhabricator

Modularize all Herald pre-commit ref fields
ClosedPublic

Authored by epriestley on Jul 8 2015, 10:40 AM.
Tags
None
Referenced Files
F19502498: D13600.id.diff
Thu, Jan 8, 4:43 PM
F19159695: D13600.id32869.diff
Dec 14 2025, 7:49 PM
F19146639: D13600.diff
Dec 10 2025, 3:32 PM
F19133674: D13600.id32870.diff
Dec 10 2025, 7:04 AM
F19132582: D13600.id32870.diff
Dec 10 2025, 6:17 AM
F19080585: D13600.id32868.diff
Dec 2 2025, 1:52 AM
F19079535: D13600.id32868.diff
Dec 1 2025, 9:14 PM
F19066726: D13600.diff
Nov 30 2025, 6:17 AM
Subscribers

Details

Summary

Ref T8726. Just (pre-commit content) one more left.

Test Plan
  • Created a big rule with every field.
  • Migrated it.
  • Verified the rule was still the same.
  • Pushed a bunch of changes and reviewed the transcripts.

Diff Detail

Repository
rP Phabricator
Branch
hmodular13
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7209
Build 7462: [Placeholder Plan] Wait for 30 Seconds
Build 7461: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Modularize all Herald pre-commit ref fields.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
  • Also handle special rendering of "Change" rule.
btrahan edited edge metadata.
btrahan added inline comments.
src/applications/herald/adapter/HeraldAdapter.php
1215–1225

nice

This revision is now accepted and ready to land.Jul 8 2015, 7:00 PM
This revision was automatically updated to reflect the committed changes.