Ref T8726. Make all the DifferentialRevision stuff modular.
Details
Details
- Reviewers
btrahan - Maniphest Tasks
- T8726: Modularize Herald fields and actions
- Commits
- Restricted Diffusion Commit
rP00b98eca541c: Modularize all DifferentialRevision fields
- Created a rule with all fields.
- Ran upgrade.
- Saw all fields preserved with new modular versions.
- Used test console to run rule with all fields, verified field values as broadly sensible.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- hmodular12
- Lint
Lint Passed Severity Location Code Message Advice src/applications/differential/herald/HeraldDifferentialRevisionAdapter.php:150 XHP16 TODO Comment - Unit
Tests Passed - Build Status
Buildable 7206 Build 7456: [Placeholder Plan] Wait for 30 Seconds Build 7455: arc lint + arc unit