Paths

Table of Contentst

Differential D13424

Add a method for determining the relative path
Needs ReviewPublic
Actions

Authored by joshuaspence on Jun 25 2015, 10:12 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Summary

Adds a Filesystem::relativePath method for determining the relative path between two specified paths. The implementation was based on a post on StackOverflow.

I am using this method in a third party library, but I figured that it is potentially useful enough to be submitted upstream.

Test Plan

Added unit tests.

Diff Detail

Repository

rPHU libphutil

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 7180
Build 7405: [Placeholder Plan] Wait for 30 Seconds
Build 7404: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 32507.Jun 25 2015, 10:12 AM

joshuaspence retitled this revision from to Add a method for determining the relative path.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 25 2015, 10:12 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Tidying

• cyn0228.ch added a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:42 PM

chad removed a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:45 PM

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

src/

filesystem/

Filesystem.php

47 lines

40%

__tests__/

FilesystemTestCase.php

44 lines

96%

Diff 32817

View Options

src/filesystem/Filesystem.php

View Options

src/filesystem/tests/FilesystemTestCase.php

Add a method for determining the relative pathNeeds ReviewPublicActions