Page MenuHomePhabricator
Differential D13571

Use PhutilClassMapQuery instead of PhutilSymbolLoader
ClosedPublic
Actions

Authored by joshuaspence on Jul 7 2015, 9:22 AM.
Tags
None
Referenced Files
F13099542: D13571.diff
Fri, Apr 26, 3:36 PM
F13097808: D13571.id32804.diff
Fri, Apr 26, 2:43 AM
F13097807: D13571.id32796.diff
Fri, Apr 26, 2:43 AM
F13097806: D13571.id.diff
Fri, Apr 26, 2:43 AM
Unknown Object (File)
Mon, Apr 22, 10:24 AM
Unknown Object (File)
Tue, Apr 16, 7:50 PM
Unknown Object (File)
Mon, Apr 8, 3:37 PM
Unknown Object (File)
Sun, Apr 7, 10:53 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHU2bac12af4c8a: Use PhutilClassMapQuery instead of PhutilSymbolLoader
Summary

Use PhutilClassMapQuery instead of PhutilSymbolLoader, mostly for consistency.

Test Plan

N/A

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7169
Build 7383: [Placeholder Plan] Wait for 30 Seconds
Build 7382: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 32796.Jul 7 2015, 9:22 AM
joshuaspence retitled this revision from to Use PhutilClassMapQuery instead of PhutilSymbolLoader.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 7 2015, 9:22 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
epriestley accepted this revision.Jul 7 2015, 12:34 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 7 2015, 12:34 PM
Closed by commit rPHU2bac12af4c8a: Use PhutilClassMapQuery instead of PhutilSymbolLoader (authored by joshuaspence, committed by joshuaspence). · Explain WhyJul 7 2015, 12:48 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
scripts/
test/
6 lines--
src/
internationalization/
5 lines12%
Loading...
markup/
engine/
remarkup/
blockrule/
4 lines100%
Loading...

Diff 32796

View Options

scripts/test/lipsum.php

Loading...
View Options

src/internationalization/PhutilLocale.php

Loading...
View Options

src/markup/engine/remarkup/blockrule/PhutilRemarkupInterpreterBlockRule.php

Loading...
Phabricator · Built by Phacility