Page MenuHomePhabricator
Differential D13500

Modularize Herald task status/priority fields
ClosedPublic
Actions

Authored by epriestley on Jul 1 2015, 12:06 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 29, 4:45 PM
Unknown Object (File)
Sun, Apr 28, 2:20 PM
Unknown Object (File)
Sat, Apr 27, 7:30 PM
Unknown Object (File)
Sat, Apr 27, 5:37 AM
Unknown Object (File)
Fri, Apr 26, 3:15 AM
Unknown Object (File)
Thu, Apr 25, 1:02 AM
Unknown Object (File)
Wed, Apr 17, 2:41 PM
Unknown Object (File)
Wed, Apr 10, 1:43 AM
View All Files
Subscribers
eadler
epriestley
joshuaspence

Details

Reviewers
btrahan
Maniphest Tasks
T8726: Modularize Herald fields and actions
Commits
Restricted Diffusion Commit
rPc02c83108d21: Modularize Herald task status/priority fields
Summary

Ref T8726. These are a bit involved because they have custom rendering and editor values.

Test Plan

Created new rule using these fields, edited tasks to trigger them, viewed transcripts.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 32655.Jul 1 2015, 12:06 AM
epriestley retitled this revision from to Modularize Herald task status/priority fields.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T8726: Modularize Herald fields and actions.
Herald added a subscriber: epriestley. · View Herald TranscriptJul 1 2015, 12:06 AM
joshuaspence added a subscriber: joshuaspence.Jul 1 2015, 2:34 AM
btrahan accepted this revision.Jul 1 2015, 5:26 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jul 1 2015, 5:26 PM
eadler added a subscriber: eadler.Jul 3 2015, 7:48 PM
Closed by commit rPc02c83108d21: Modularize Herald task status/priority fields (authored by epriestley, committed by epriestley). · Explain WhyJul 6 2015, 8:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 32783

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/herald/adapter/HeraldAdapter.php

Loading...
View Options

src/applications/herald/adapter/HeraldManiphestTaskAdapter.php

Loading...
View Options

src/applications/herald/controller/HeraldRuleController.php

Loading...
View Options

src/applications/herald/controller/HeraldRuleViewController.php

Loading...
View Options

src/applications/herald/field/HeraldField.php

Loading...
View Options

src/applications/maniphest/herald/HeraldManiphestTaskAdapter.php

Loading...
View Options

src/applications/maniphest/herald/ManiphestHeraldField.php

Loading...
View Options

src/applications/maniphest/herald/ManiphestTaskPriorityHeraldField.php

Loading...
View Options

src/applications/maniphest/herald/ManiphestTaskStatusHeraldField.php

Loading...
Phabricator · Built by Phacility