Page MenuHomePhabricator
Differential D13497

Make Herald custom field integration modular
ClosedPublic
Actions

Authored by epriestley on Jun 30 2015, 11:00 PM.
Tags
None
Referenced Files
F15416342: D13497.id32780.diff
Thu, Mar 20, 10:34 AM
F15397169: D13497.id.diff
Sun, Mar 16, 6:35 PM
F15392893: D13497.id32652.diff
Sat, Mar 15, 6:17 PM
F15391934: D13497.id32780.diff
Sat, Mar 15, 12:25 PM
F15391656: D13497.id.diff
Sat, Mar 15, 10:53 AM
F15344450: D13497.diff
Mon, Mar 10, 4:39 AM
Unknown Object (File)
Mon, Mar 3, 1:59 PM
Unknown Object (File)
Thu, Feb 27, 8:59 AM
View All Files
Subscribers
eadler
epriestley
joshuaspence

Details

Reviewers
btrahan
Maniphest Tasks
T8726: Modularize Herald fields and actions
Commits
Restricted Diffusion Commit
rP4c23d5cfae54: Make Herald custom field integration modular
Summary

Ref T8726. The existing implementation is largely made redundant by the newer modular implementation.

Test Plan

Created a custom field rule, set custom field to various values until it matched, saw effect and proper transcripts.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 32652.Jun 30 2015, 11:00 PM
epriestley retitled this revision from to Make Herald custom field integration modular.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T8726: Modularize Herald fields and actions.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 30 2015, 11:00 PM
joshuaspence added a subscriber: joshuaspence.Jul 1 2015, 2:32 AM
btrahan accepted this revision.Jul 1 2015, 5:04 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jul 1 2015, 5:04 PM
eadler added a subscriber: eadler.Jul 3 2015, 7:49 PM
Closed by commit rP4c23d5cfae54: Make Herald custom field integration modular (authored by epriestley, committed by epriestley). · Explain WhyJul 6 2015, 8:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
herald/
adapter/
222 lines
field/
12 lines
infrastructure/
customfield/
herald/
68 lines

Diff 32780

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/herald/adapter/HeraldAdapter.php

Loading...
View Options

src/applications/herald/field/HeraldField.php

Loading...
View Options

src/infrastructure/customfield/herald/PhabricatorCustomFieldHeraldField.php

Loading...
Phabricator · Built by Phacility