Page MenuHomePhabricator
Differential D13493

Throw on accessing an undeclared property
ClosedPublic
Actions

Authored by joshuaspence on Jun 30 2015, 10:01 PM.
Tags
None
Referenced Files
F13883032: D13493.diff
Thu, Oct 3, 5:27 AM
Unknown Object (File)
Sat, Sep 21, 11:27 PM
Unknown Object (File)
Sat, Sep 21, 11:26 PM
Unknown Object (File)
Sat, Sep 21, 11:26 PM
Unknown Object (File)
Sat, Sep 21, 11:16 PM
Unknown Object (File)
Sep 1 2024, 3:24 PM
Unknown Object (File)
Aug 30 2024, 12:11 AM
Unknown Object (File)
Aug 29 2024, 5:38 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHUfffe7e4ef4c8: Throw on accessing an undeclared property
Summary

Currently, Phobject throws when trying to set an undeclared property but not when trying to get an undeclared property. It seems reasonable to add this functionality.

Test Plan

Added unit tests.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 32644.Jun 30 2015, 10:01 PM
joshuaspence retitled this revision from to Throw on accessing an undeclared property.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 30 2015, 10:01 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
epriestley accepted this revision.Jun 30 2015, 10:14 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 30 2015, 10:14 PM
joshuaspence mentioned this in D13511: Initialize a class property.Jul 1 2015, 11:52 AM
Closed by commit rPHUfffe7e4ef4c8: Throw on accessing an undeclared property (authored by joshuaspence, committed by joshuaspence). · Explain WhyJul 6 2015, 1:12 PM
This revision was automatically updated to reflect the committed changes.
joshuaspence mentioned this in rPHU112843f63e35: Initialize a class property.

Revision Contents
Changeset List

PathSize
src/
4 lines
object/
7 lines
__tests__/
PhobjectTestCase.php
PhutilPhobjectTestCase.php
11 lines

Diff 32764

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/object/Phobject.php

Loading...
View Options

src/object/__tests__/PhobjectTestCase.php

Loading...
View Options

src/object/__tests__/PhutilPhobjectTestCase.php

Loading...
Phabricator · Built by Phacility