Page MenuHomePhabricator
Differential D13493

Throw on accessing an undeclared property
ClosedPublic
Actions

Authored by joshuaspence on Jun 30 2015, 10:01 PM.
Tags
None
Referenced Files
F14577686: D13493.diff
Wed, Jan 8, 3:05 AM
Unknown Object (File)
Sun, Dec 29, 7:08 PM
Unknown Object (File)
Fri, Dec 27, 6:47 PM
Unknown Object (File)
Wed, Dec 25, 8:30 PM
Unknown Object (File)
Tue, Dec 10, 7:37 PM
Unknown Object (File)
Dec 7 2024, 8:48 AM
Unknown Object (File)
Nov 30 2024, 11:49 AM
Unknown Object (File)
Nov 20 2024, 7:58 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHUfffe7e4ef4c8: Throw on accessing an undeclared property
Summary

Currently, Phobject throws when trying to set an undeclared property but not when trying to get an undeclared property. It seems reasonable to add this functionality.

Test Plan

Added unit tests.

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7071
Build 7195: [Placeholder Plan] Wait for 30 Seconds
Build 7194: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 32644.Jun 30 2015, 10:01 PM
joshuaspence retitled this revision from to Throw on accessing an undeclared property.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 30 2015, 10:01 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
epriestley accepted this revision.Jun 30 2015, 10:14 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 30 2015, 10:14 PM
joshuaspence mentioned this in D13511: Initialize a class property.Jul 1 2015, 11:52 AM
Closed by commit rPHUfffe7e4ef4c8: Throw on accessing an undeclared property (authored by joshuaspence, committed by joshuaspence). · Explain WhyJul 6 2015, 1:12 PM
This revision was automatically updated to reflect the committed changes.
joshuaspence mentioned this in rPHU112843f63e35: Initialize a class property.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
src/
4 lines--
object/
7 lines59%
Loading...
__tests__/
PhobjectTestCase.php
PhutilPhobjectTestCase.php
11 lines--
--

Diff 32644

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/object/Phobject.php

Loading...
View Options

src/object/__tests__/PhobjectTestCase.php

Loading...
View Options

src/object/__tests__/PhutilPhobjectTestCase.php

Loading...
Phabricator · Built by Phacility