[Redesign] Set a max-width on Graphviz
ClosedPublic
Actions

Authored by chad on Jul 3 2015, 10:57 PM.

Details

Reviewers

epriestley
btrahan

Maniphest Tasks

T8750: Graphviz remarkup blocks produce graphs too wide to display

Commits

Restricted Diffusion Commit
rP54194acd39d6: [Redesign] Set a max-width on Graphviz

Summary

Ref T8750, Adds a maxwidth class for Graphviz images.

Test Plan

Generate a Graphviz image, really big, see it scale to the viewport.

Diff Detail

Repository

rP Phabricator

Branch

graphviz

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 7137
Build 7322: [Placeholder Plan] Wait for 30 Seconds
Build 7321: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 32735.Jul 3 2015, 10:57 PM

chad retitled this revision from to [Redesign] Set a max-width on Graphviz.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, btrahan.

chad added a task: T8750: Graphviz remarkup blocks produce graphs too wide to display.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJul 3 2015, 10:57 PM

chad mentioned this in T8750: Graphviz remarkup blocks produce graphs too wide to display.Jul 3 2015, 11:01 PM

epriestley accepted this revision.Jul 4 2015, 8:13 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jul 4 2015, 8:13 PM

Closed by commit rP54194acd39d6: [Redesign] Set a max-width on Graphviz (authored by chad, committed by chad). · Explain WhyJul 4 2015, 8:17 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

markup/

interpreter/

PhabricatorRemarkupGraphvizBlockInterpreter.php

3 lines

Diff 32735

View Options

src/infrastructure/markup/interpreter/PhabricatorRemarkupGraphvizBlockInterpreter.php

[Redesign] Set a max-width on GraphvizClosedPublicActions