Page MenuHomePhabricator

Modularize Herald task status/priority fields
ClosedPublic

Authored by epriestley on Jul 1 2015, 12:06 AM.
Tags
None
Referenced Files
F14371290: D13500.id.diff
Fri, Dec 20, 6:52 PM
F14361912: D13500.id32655.diff
Fri, Dec 20, 12:09 PM
Unknown Object (File)
Wed, Dec 11, 11:28 AM
Unknown Object (File)
Sat, Nov 30, 3:51 PM
Unknown Object (File)
Tue, Nov 26, 7:10 PM
Unknown Object (File)
Fri, Nov 22, 12:03 AM
Unknown Object (File)
Nov 18 2024, 12:14 AM
Unknown Object (File)
Nov 13 2024, 4:37 PM

Details

Summary

Ref T8726. These are a bit involved because they have custom rendering and editor values.

Test Plan

Created new rule using these fields, edited tasks to trigger them, viewed transcripts.

Diff Detail

Repository
rP Phabricator
Branch
hmodular6
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/herald/field/HeraldField.php:56XHP16TODO Comment
Advicesrc/applications/herald/field/HeraldField.php:81XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 7079
Build 7210: [Placeholder Plan] Wait for 30 Seconds
Build 7209: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Modularize Herald task status/priority fields.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jul 1 2015, 5:26 PM
This revision was automatically updated to reflect the committed changes.