Page MenuHomePhabricator

Make Herald custom field integration modular
ClosedPublic

Authored by epriestley on Jun 30 2015, 11:00 PM.
Tags
None
Referenced Files
F14090489: D13497.id32652.diff
Sun, Nov 24, 6:20 PM
Unknown Object (File)
Sat, Nov 23, 1:23 PM
Unknown Object (File)
Thu, Nov 21, 10:55 PM
Unknown Object (File)
Thu, Nov 21, 10:54 PM
Unknown Object (File)
Sun, Nov 17, 4:39 PM
Unknown Object (File)
Thu, Nov 14, 12:30 AM
Unknown Object (File)
Sun, Nov 10, 4:00 AM
Unknown Object (File)
Wed, Nov 6, 11:49 AM

Details

Summary

Ref T8726. The existing implementation is largely made redundant by the newer modular implementation.

Test Plan

Created a custom field rule, set custom field to various values until it matched, saw effect and proper transcripts.

Diff Detail

Repository
rP Phabricator
Branch
hmodular3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7076
Build 7204: [Placeholder Plan] Wait for 30 Seconds
Build 7203: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Make Herald custom field integration modular.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jul 1 2015, 5:04 PM
This revision was automatically updated to reflect the committed changes.