Paths

Table of Contentst

Differential D13493

Throw on accessing an undeclared property
ClosedPublic
Actions

Authored by joshuaspence on Jun 30 2015, 10:01 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rPHUfffe7e4ef4c8: Throw on accessing an undeclared property

Summary

Currently, Phobject throws when trying to set an undeclared property but not when trying to get an undeclared property. It seems reasonable to add this functionality.

Test Plan

Added unit tests.

Diff Detail

Repository

rPHU libphutil

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 7071
Build 7195: [Placeholder Plan] Wait for 30 Seconds
Build 7194: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 32644.Jun 30 2015, 10:01 PM

joshuaspence retitled this revision from to Throw on accessing an undeclared property.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 30 2015, 10:01 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

epriestley accepted this revision.Jun 30 2015, 10:14 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 30 2015, 10:14 PM

joshuaspence mentioned this in D13511: Initialize a class property.Jul 1 2015, 11:52 AM

Closed by commit rPHUfffe7e4ef4c8: Throw on accessing an undeclared property (authored by joshuaspence, committed by joshuaspence). · Explain WhyJul 6 2015, 1:12 PM

This revision was automatically updated to reflect the committed changes.

joshuaspence mentioned this in rPHU112843f63e35: Initialize a class property.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

src/

__phutil_library_map__.php

4 lines

object/

Phobject.php

7 lines

59%

__tests__/

	PhobjectTestCase.php
	PhutilPhobjectTestCase.php

11 lines

PhutilPhobjectTestCase.php

Diff 32644

View Options

src/__phutil_library_map__.php

View Options

src/object/Phobject.php

View Options

src/object/tests/PhobjectTestCase.php

View Options

src/object/tests/PhutilPhobjectTestCase.php

Throw on accessing an undeclared propertyClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 32644

src/__phutil_library_map__.php

src/object/Phobject.php

src/object/__tests__/PhobjectTestCase.php

src/object/__tests__/PhutilPhobjectTestCase.php

Throw on accessing an undeclared property
ClosedPublic
Actions

Revision Contents
Changeset List

src/object/tests/PhobjectTestCase.php

src/object/tests/PhutilPhobjectTestCase.php