Page MenuHomePhabricator
Differential D13482

Let PhabricatorPlatformSite catch unconfigured requests
ClosedPublic
Actions

Authored by avivey on Jun 30 2015, 3:59 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 6:03 AM
Unknown Object (File)
Tue, Dec 10, 6:33 PM
Unknown Object (File)
Mon, Dec 9, 12:14 PM
Unknown Object (File)
Mon, Dec 9, 12:14 PM
Unknown Object (File)
Mon, Dec 9, 12:14 PM
Unknown Object (File)
Mon, Dec 9, 11:57 AM
Unknown Object (File)
Fri, Dec 6, 4:46 PM
Unknown Object (File)
Wed, Nov 27, 5:20 PM
View All Files
Subscribers
epriestley
Korvin
laomoi

Details

Reviewers
epriestley
laomoi
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T8717: Bad error when first installing phabricator
Commits
Restricted Diffusion Commit
rP9eda21451a44: Let PhabricatorPlatformSite catch unconfigured requests
Summary

Fix T8717. If the install didn't configure base-uri, assume they want Phabricator; We'll later show the setup warning about it.

Test Plan

Set base-uri to something else, see short error. Delete it, see Phabricator.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7057
Build 7167: [Placeholder Plan] Wait for 30 Seconds
Build 7166: arc lint + arc unit

Event Timeline

avivey updated this revision to Diff 32620.Jun 30 2015, 3:59 AM
avivey retitled this revision from to Let PhabricatorPlatformSite catch unconfigured requests.
avivey updated this object.
avivey edited the test plan for this revision. (Show Details)
avivey added a reviewer: epriestley.
avivey added a task: T8717: Bad error when first installing phabricator.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 30 2015, 3:59 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
avivey updated this object.Jun 30 2015, 3:59 AM
avivey edited edge metadata.
laomoi accepted this revision.Jun 30 2015, 10:53 AM
laomoi added a reviewer: laomoi.
laomoi added a subscriber: laomoi.

cool code , for test

epriestley accepted this revision.Jun 30 2015, 2:23 PM
epriestley edited edge metadata.

Oh, sorry, I missed this. See D13483. I'm just going to land that change as this, since they're functionally identical except for meaningless base uri 0.

This revision is now accepted and ready to land.Jun 30 2015, 2:23 PM
epriestley mentioned this in D13483: Return the PlatformSite if no base URI is configured yet.Jun 30 2015, 2:23 PM
Closed by commit rP9eda21451a44: Let PhabricatorPlatformSite catch unconfigured requests (authored by epriestley, committed by epriestley). · Explain WhyJun 30 2015, 2:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
aphront/
site/
5 lines

Diff 32620

View Options

src/aphront/site/PhabricatorPlatformSite.php

Loading...
Phabricator · Built by Phacility