Return the PlatformSite if no base URI is configured yet
AbandonedPublic
Actions

Authored by epriestley on Jun 30 2015, 12:20 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Dec 16, 6:46 PM

	Unknown Object (File)
	Fri, Dec 13, 9:38 PM

	Unknown Object (File)
	Tue, Dec 10, 3:05 PM

	Unknown Object (File)
	Fri, Dec 6, 4:07 PM

	Unknown Object (File)
	Wed, Dec 4, 4:42 AM

	Unknown Object (File)
	Nov 23 2024, 10:27 AM

	Unknown Object (File)
	Nov 22 2024, 1:19 AM

	Unknown Object (File)
	Oct 24 2024, 9:23 AM

View All Files

Subscribers

epriestley

Details

Reviewers

btrahan

Maniphest Tasks

T8717: Bad error when first installing phabricator

Summary

Fixes T8717. The old logic was a little hard to follow so I didn't port this behavior correctly: when no base-uri is configured, we should match the main ("Platform") site.

Test Plan

Un-configured base-uri, things worked again.

Diff Detail

Repository

rP Phabricator

Branch

nosite

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 7058
Build 7169: [Placeholder Plan] Wait for 30 Seconds
Build 7168: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 32621.Jun 30 2015, 12:20 PM

epriestley retitled this revision from to Return the PlatformSite if no base URI is configured yet.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T8717: Bad error when first installing phabricator.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 30 2015, 12:20 PM

See D13482.

Revision Contents
Changeset List

Path

Size

src/

aphront/

site/

PhabricatorPlatformSite.php

9 lines

Diff 32621

View Options

src/aphront/site/PhabricatorPlatformSite.php

Return the PlatformSite if no base URI is configured yetAbandonedPublicActions