Page MenuHomePhabricator
Differential D13481

Commenting on instances of a recurring event should create a new event with its own comments
ClosedPublic
Actions

Authored by lpriestley on Jun 29 2015, 10:41 PM.
Tags
None
Referenced Files
F14062118: D13481.diff
Mon, Nov 18, 10:36 AM
F14049324: D13481.diff
Thu, Nov 14, 12:35 PM
F14048120: D13481.diff
Thu, Nov 14, 6:49 AM
F14036435: D13481.diff
Sun, Nov 10, 10:15 AM
F14031148: D13481.diff
Sat, Nov 9, 9:28 AM
F14021068: D13481.diff
Wed, Nov 6, 5:01 AM
F13996816: D13481.diff
Thu, Oct 24, 12:08 AM
F13989135: D13481.id32638.diff
Mon, Oct 21, 6:20 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T8696: User comments in recurring events should be added per instance
Commits
Restricted Diffusion Commit
rP28e0af5a62c8: Commenting on instances of a recurring event should create a new event with…
Summary

Closes T8696, Commenting on instances of a recurring event should create a new event with its own comments

Test Plan

Open recurring event instance (not exception), should see no timeline, leave a comment, an exception to event should be created.

Diff Detail

Repository
rP Phabricator
Branch
calendarrecurringcomments
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7056
Build 7165: [Placeholder Plan] Wait for 30 Seconds
Build 7164: arc lint + arc unit

Event Timeline

lpriestley updated this revision to Diff 32619.Jun 29 2015, 10:41 PM
lpriestley retitled this revision from to Commenting on instances of a recurring event should create a new event with its own comments.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley added a task: T8696: User comments in recurring events should be added per instance.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 29 2015, 10:41 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
epriestley accepted this revision.Jun 29 2015, 10:51 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/calendar/controller/PhabricatorCalendarEventViewController.php
91

Sometimes no $sequence in this

This revision is now accepted and ready to land.Jun 29 2015, 10:51 PM
lpriestley updated this revision to Diff 32638.Jun 30 2015, 6:47 PM
lpriestley edited edge metadata.

$sequence only when it exists

Closed by commit rP28e0af5a62c8: Commenting on instances of a recurring event should create a new event with… (authored by lpriestley, committed by lpriestley). · Explain WhyJun 30 2015, 6:47 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 32619

View Options

src/applications/calendar/application/PhabricatorCalendarApplication.php

Loading...
View Options

src/applications/calendar/controller/PhabricatorCalendarEventCommentController.php

Loading...
View Options

src/applications/calendar/controller/PhabricatorCalendarEventViewController.php

Loading...
Phabricator · Built by Phacility