Page MenuHomePhabricator

Commenting on instances of a recurring event should create a new event with its own comments
ClosedPublic

Authored by lpriestley on Jun 29 2015, 10:41 PM.
Tags
None
Referenced Files
F14062118: D13481.diff
Mon, Nov 18, 10:36 AM
F14049324: D13481.diff
Thu, Nov 14, 12:35 PM
F14048120: D13481.diff
Thu, Nov 14, 6:49 AM
F14036435: D13481.diff
Sun, Nov 10, 10:15 AM
F14031148: D13481.diff
Sat, Nov 9, 9:28 AM
F14021068: D13481.diff
Wed, Nov 6, 5:01 AM
F13996816: D13481.diff
Thu, Oct 24, 12:08 AM
F13989135: D13481.id32638.diff
Mon, Oct 21, 6:20 PM
Subscribers

Details

Summary

Closes T8696, Commenting on instances of a recurring event should create a new event with its own comments

Test Plan

Open recurring event instance (not exception), should see no timeline, leave a comment, an exception to event should be created.

Diff Detail

Repository
rP Phabricator
Branch
calendarrecurringcomments
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7067
Build 7187: [Placeholder Plan] Wait for 30 Seconds
Build 7186: arc lint + arc unit

Event Timeline

lpriestley retitled this revision from to Commenting on instances of a recurring event should create a new event with its own comments.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/calendar/controller/PhabricatorCalendarEventViewController.php
97

Sometimes no $sequence in this

This revision is now accepted and ready to land.Jun 29 2015, 10:51 PM
lpriestley edited edge metadata.

$sequence only when it exists

This revision was automatically updated to reflect the committed changes.