Page MenuHomePhabricator

User comments in recurring events should be added per instance
Closed, ResolvedPublic

Description

User comments for a recurring event currently appear on all instances of the event. Since I'd like to use recurring events for weekly meetings, I'd also like to add the meeting minutes to each recurring event as a comment. To make this work comments should be assigned to individual event instances, and not to all instances of the recurring event.

Event Timeline

tiguchi raised the priority of this task from to Needs Triage.
tiguchi updated the task description. (Show Details)
tiguchi added a project: Calendar.
tiguchi added a subscriber: tiguchi.

My main concern here is we already have a tool for documenting things with Phriction. Changelog is a good example of what you are describing. We keep it updated every week.

https://secure.phabricator.com/book/phabcontrib/article/feature_requests/ has more information on what we look for in feature requests. Specifically, we want to understand the core problem and then determine what the solution is (documenting meetings doesn't seem like something that should be inside of Calendar).

Interesting point, @chad. I do still think that the current commenting behavior on recurring events is inconsistent. Ghost event exceptions are real live events, so they have their own comments, but other generated ghost events are not, and they all share comments with their parent. I think the way forward here is to convert ghost events to real events if you want to leave a comment on them.

If there's interest and there's a good use case for it, we can talk about somehow coupling Phriction and Calendar. Maybe a "Tag a Phriction Document" option on events...

I agree with @chad and @lpriestley: meeting minutes on calendar events would be hard to find or search. Typically one doesn't remember the day the meeting took place, they remember the type of meeting and search all the minutes. Being able to tag wiki articles with a date or calendar would be useful though: or being able to couple an agenda + minutes + calendar entry.

OK, let's just forget about meeting minutes for Phabricator's calendar app. It may be a bad example from your point of view (even though I am not completely sold to using Phriction instead, due to the lack of a nice calendar view that makes it easier to browse events in a familiar way).

I just find it completely counter-intuitive that a comment appears on all instances of a recurring event. Let's assume I would use comments only to discuss an upcoming event, and I'd like to use the comment section to tell my colleagues that I won't have time, or that I'll be in charge of bringing the barbecue meat or something like that. That comment that was only meant for a single instance of the recurring event pops up everywhere now. I don't want to be in charge of the barbecue meat for the rest of my life :-(
I think it is confusing to see older comments on newer events, and the comment thread may get out of hand after a while.

However, maybe I also do not quite understand what the comment section under calendar events is good for. At least in case of recurring events I do not understand that behavior.

Calendar is a prototype application, meaning it's unfinished, buggy, and still undergoing major changes. We generally prefer not to take bug reports or feature requests on prototypes.

https://secure.phabricator.com/book/phabricator/article/prototypes/

I'm also in no way arguing against making these all individually commentable, I just try to look at core problems presented and make sure we solve the actual proble you are having and not just implanting random features. If there is some way to make Phriction work better for documenting recurring meetings, I'm generally more in favor of that.

Yes, recurring events should be individually commentable. Meeting minutes can be a separate discussion.