Page MenuHomePhabricator
Differential D13462

Remove duplicated duplicated words
ClosedPublic
Actions

Authored by eadler on Jun 26 2015, 9:26 PM.
Tags
None
Referenced Files
F13172234: D13462.diff
Tue, May 7, 2:35 PM
Unknown Object (File)
Fri, May 3, 3:30 AM
Unknown Object (File)
Mon, Apr 29, 3:19 PM
Unknown Object (File)
Sun, Apr 28, 5:30 AM
Unknown Object (File)
Wed, Apr 24, 11:08 PM
Unknown Object (File)
Sun, Apr 21, 9:14 PM
Unknown Object (File)
Sun, Apr 21, 9:14 PM
Unknown Object (File)
Sun, Apr 21, 9:04 PM
View All Files
Subscribers
epriestley

Details

Reviewers
joshuaspence
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP2536febed39b: Remove duplicated duplicated words
Test Plan

eyeball it

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7033
Build 7120: [Placeholder Plan] Wait for 30 Seconds
Build 7119: arc lint + arc unit

Event Timeline

eadler updated this revision to Diff 32578.Jun 26 2015, 9:26 PM
eadler retitled this revision from to Remove duplicated duplicated words.
eadler updated this object.
eadler edited the test plan for this revision. (Show Details)
eadler added a reviewer: joshuaspence.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 26 2015, 9:26 PM
Herald added a subscriber: epriestley. · View Herald Transcript
joshuaspence accepted this revision.Jun 26 2015, 11:17 PM
joshuaspence edited edge metadata.
epriestley accepted this revision.Jun 27 2015, 3:43 PM
epriestley added a reviewer: epriestley.
epriestley added inline comments.
src/applications/diviner/storage/DivinerLiveSymbol.php
153

I think this one is technically intentional -- the unique tuple is enormously long, "way, way too long".

This revision is now accepted and ready to land.Jun 27 2015, 3:43 PM
Closed by commit rP2536febed39b: Remove duplicated duplicated words (authored by eadler, committed by epriestley). · Explain WhyJun 27 2015, 3:43 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
config/
check/
2 lines
diviner/
storage/
2 lines
files/
storage/
__tests__/
2 lines
repository/
graphcache/
2 lines
transactions/
editor/
2 lines

Diff 32578

View Options

src/applications/config/check/PhabricatorTimezoneSetupCheck.php

Loading...
View Options

src/applications/diviner/storage/DivinerLiveSymbol.php

Loading...
View Options

src/applications/files/storage/__tests__/PhabricatorFileTestCase.php

Loading...
View Options

src/applications/repository/graphcache/PhabricatorRepositoryGraphCache.php

Loading...
View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
Phabricator · Built by Phacility