Page MenuHomePhabricator

show key name when map value is of wrong type
ClosedPublic

Authored by avivey on Jun 26 2015, 6:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 22, 4:38 AM
Unknown Object (File)
Fri, Nov 22, 1:19 AM
Unknown Object (File)
Fri, Nov 22, 1:19 AM
Unknown Object (File)
Fri, Nov 22, 1:19 AM
Unknown Object (File)
Thu, Nov 21, 12:40 PM
Unknown Object (File)
Thu, Nov 21, 7:28 AM
Unknown Object (File)
Wed, Nov 20, 9:28 PM
Unknown Object (File)
Sun, Nov 17, 3:34 AM

Details

Test Plan

before:

$ arc lint
Exception
Error in parsing '.arclint' file, for linter 'Anonymizable fields'.
Parameter has invalid type. Expected a regular expression, but value is not valid: preg_match(): Delimiter must not be alphanumeric or backslash
(Run with `--trace` for a full exception trace.)

after:

$ arc lint
Exception
Error in parsing '.arclint' file, for linter 'Anonymizable fields'.
Parameter 'script-and-regex.regex' has invalid type. Expected a regular expression, but value is not valid: preg_match(): Delimiter must not be alphanumeric or backslash
(Run with `--trace` for a full exception trace.)

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7027
Build 7108: [Placeholder Plan] Wait for 30 Seconds
Build 7107: arc lint + arc unit

Event Timeline

avivey retitled this revision from to show key name when map value is of wrong type.
avivey updated this object.
avivey edited the test plan for this revision. (Show Details)
avivey added reviewers: epriestley, joshuaspence.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 26 2015, 8:21 PM
This revision was automatically updated to reflect the committed changes.