Page MenuHomePhabricator
Differential D13436

Don't fail lint builds for "advice"; make lint/unit upload failures louder
ClosedPublic
Actions

Authored by epriestley on Jun 25 2015, 2:02 PM.
Tags
None
Referenced Files
F15527839: D13436.id32525.diff
Tue, Apr 22, 6:53 AM
F15524448: D13436.diff
Mon, Apr 21, 8:05 AM
F15459619: D13436.id32538.diff
Mon, Mar 31, 2:43 PM
F15436941: D13436.id32538.diff
Tue, Mar 25, 4:48 PM
F15424951: D13436.id.diff
Mar 23 2025, 1:19 AM
F15422327: D13436.id32525.diff
Mar 22 2025, 7:18 AM
F15421606: D13436.diff
Mar 22 2025, 1:17 AM
F15419857: D13436.diff
Mar 21 2025, 9:27 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T8657: Harbormaster v1 Errata
T8670: Harbormaster autoplan targets do not always complete
Commits
rARC29839e8c72c5: Don't fail lint builds for "advice"; make lint/unit upload failures louder
Summary

Ref T8670. Ref T8657.

  • When lint only has advice (no warnings/errors), consider it a "passing" build.
  • Be a little louder about sendmessage calls failing because this stuff is not totally broken and that makes T8670-related things easier to catch/fix.
Test Plan

Created this revision.

Diff Detail

Repository
rARC Arcanist
Branch
advice
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/workflow/ArcanistDiffWorkflow.php:2790XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 7005
Build 7065: [Placeholder Plan] Wait for 30 Seconds
Build 7064: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 32525.Jun 25 2015, 2:02 PM
epriestley retitled this revision from to Don't fail lint builds for "advice"; make lint/unit upload failures louder.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added tasks: T8670: Harbormaster autoplan targets do not always complete, T8657: Harbormaster v1 Errata.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 25 2015, 2:02 PM
epriestley mentioned this in T8670: Harbormaster autoplan targets do not always complete.Jun 25 2015, 2:03 PM
btrahan accepted this revision.Jun 25 2015, 5:02 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jun 25 2015, 5:02 PM
Closed by commit rARC29839e8c72c5: Don't fail lint builds for "advice"; make lint/unit upload failures louder (authored by epriestley, committed by epriestley). · Explain WhyJun 25 2015, 5:05 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
workflow/
17 lines

Diff 32525

View Options

src/workflow/ArcanistDiffWorkflow.php

Loading...
Phabricator · Built by Phacility