Use PhutilClassMapQuery where appropriate.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- rARC4d6d3feb7fc1: Use PhutilClassMapQuery
arc unit
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Branch
- master
- Lint
Lint Passed - Unit
Test Failures - Build Status
Buildable 6995 Build 7046: [Placeholder Plan] Wait for 30 Seconds Build 7045: arc lint + arc unit
| Time | Test | |
|---|---|---|
| 1,936 ms | ArcanistJSHintLinterTestCase::testLinter | |
| 1,168 ms | ArcanistCSSLintLinterTestCase::testLinter | |
| 235 ms | ArcanistCSSLintLinterTestCase::testVersion | |
| 316 ms | ArcanistChmodLinterTestCase::testLinter | |
| 799 ms | ArcanistClosureLinterTestCase::testLinter | |
| View Full Test Results (1 Failed · 48 Passed · 9 Skipped) |
Event Timeline
Comment Actions
Oh, there's also a bunch of additional places where it maybe makes sense to use PhutilClassMapQuery instead of PhutilSymbolLoader just because of the cacheing... what do you thnk?
For example, in ArcanistConfigurationDrivenLintEngine we do this:
$linters = id(new PhutilSymbolLoader()) ->setAncestorClass('ArcanistLinter') ->loadObjects();
Comment Actions
I think it's probably good to use it everywhere -- the caching probably isn't too important, but I think it's more consistent and makes intent more clear.