Page MenuHomePhabricator

Use PhutilClassMapQuery
ClosedPublic

Authored by joshuaspence on Jun 25 2015, 12:15 PM.
Tags
None
Referenced Files
F15461750: D13428.id32511.diff
Tue, Apr 1, 10:57 AM
F15457212: D13428.diff
Sun, Mar 30, 2:59 PM
F15453407: D13428.id32797.diff
Sat, Mar 29, 11:31 AM
F15448506: D13428.id.diff
Fri, Mar 28, 5:20 AM
F15445918: D13428.id32511.diff
Thu, Mar 27, 4:32 PM
F15444605: D13428.id.diff
Thu, Mar 27, 10:18 AM
F15441164: D13428.diff
Wed, Mar 26, 4:46 PM
F15439832: D13428.diff
Wed, Mar 26, 9:41 AM
Subscribers

Details

Summary

Use PhutilClassMapQuery where appropriate.

Test Plan

arc unit

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Use PhutilClassMapQuery.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 25 2015, 12:16 PM

Oh, there's also a bunch of additional places where it maybe makes sense to use PhutilClassMapQuery instead of PhutilSymbolLoader just because of the cacheing... what do you thnk?

For example, in ArcanistConfigurationDrivenLintEngine we do this:

$linters = id(new PhutilSymbolLoader())
  ->setAncestorClass('ArcanistLinter')
  ->loadObjects();

I think it's probably good to use it everywhere -- the caching probably isn't too important, but I think it's more consistent and makes intent more clear.

This revision was automatically updated to reflect the committed changes.