Page MenuHomePhabricator
Differential D13380

Allow lint and unit results to be reported via `harbormaster.sendmessage`
ClosedPublic
Actions

Authored by epriestley on Jun 21 2015, 5:57 PM.
Tags
None
Referenced Files
F13175576: D13380.diff
Wed, May 8, 5:57 AM
Unknown Object (File)
Tue, May 7, 5:27 AM
Unknown Object (File)
Fri, May 3, 2:53 AM
Unknown Object (File)
Thu, May 2, 6:14 AM
Unknown Object (File)
Mon, Apr 29, 2:34 PM
Unknown Object (File)
Wed, Apr 24, 10:39 PM
Unknown Object (File)
Wed, Apr 17, 3:14 PM
Unknown Object (File)
Thu, Apr 11, 7:36 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T8095: Let Harbormaster own Lint and Unit results
Commits
Restricted Diffusion Commit
rP41b3f9236a77: Allow lint and unit results to be reported via `harbormaster.sendmessage`
Summary

Ref T8095. When build results are reported for a target, allow them to include unit and lint results.

There is no real way to see this stuff in the UI yet, either in Harbormaster or Differential.

Test Plan

Manually called this method with some results, saw Harbormaster update appropriately.

Diff Detail

Repository
rP Phabricator
Branch
unit4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 6922
Build 6944: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 32392.Jun 21 2015, 5:57 PM
epriestley retitled this revision from to Allow lint and unit results to be reported via `harbormaster.sendmessage`.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T8095: Let Harbormaster own Lint and Unit results.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 21 2015, 5:57 PM
epriestley updated this revision to Diff 32393.Jun 21 2015, 6:29 PM
  • Also return phid from diff creation so we can get autotargets.
btrahan accepted this revision.Jun 22 2015, 5:03 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jun 22 2015, 5:03 PM
Closed by commit rP41b3f9236a77: Allow lint and unit results to be reported via `harbormaster.sendmessage` (authored by epriestley, committed by epriestley). · Explain WhyJun 23 2015, 5:24 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T7617: Make it easier to know why herald adds reviewers.Dec 11 2015, 2:27 AM

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
conduit/
3 lines
harbormaster/
conduit/
31 lines
controller/
8 lines

Diff 32393

View Options

src/applications/differential/conduit/DifferentialCreateDiffConduitAPIMethod.php

Loading...
View Options

src/applications/harbormaster/conduit/HarbormasterSendMessageConduitAPIMethod.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterBuildableViewController.php

Loading...
Phabricator · Built by Phacility