Page MenuHomePhabricator
Differential D13379

Remove weird "Differential Results Table" view
ClosedPublic
Actions

Authored by epriestley on Jun 21 2015, 5:42 PM.
Tags
None
Referenced Files
F13162745: D13379.diff
Mon, May 6, 3:29 PM
Unknown Object (File)
Fri, May 3, 4:31 AM
Unknown Object (File)
Mon, Apr 29, 4:34 PM
Unknown Object (File)
Thu, Apr 25, 12:14 AM
Unknown Object (File)
Tue, Apr 16, 4:17 PM
Unknown Object (File)
Thu, Apr 11, 8:29 AM
Unknown Object (File)
Mar 18 2024, 8:47 AM
Unknown Object (File)
Mar 14 2024, 5:05 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
chad
Maniphest Tasks
T8095: Let Harbormaster own Lint and Unit results
Commits
Restricted Diffusion Commit
rP831c18e6be3b: Remove weird "Differential Results Table" view
Summary

Ref T8095. This weird grey table has no remaining callsites and can be removed.

Test Plan

Grepped for symbols.

Diff Detail

Repository
rP Phabricator
Branch
unit3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 6920
Build 6942: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 32391.Jun 21 2015, 5:42 PM
epriestley retitled this revision from to Remove weird "Differential Results Table" view.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T8095: Let Harbormaster own Lint and Unit results.
Herald added a reviewer: chad. · View Herald TranscriptJun 21 2015, 5:42 PM
Herald added a subscriber: epriestley. · View Herald Transcript
chad edited edge metadata.Jun 21 2015, 5:43 PM

itsawesome

epriestley added a comment.Jun 21 2015, 5:54 PM

i made a mess 4 u to fix tho :3

chad added a comment.Jun 21 2015, 6:26 PM

spodermancoffee

btrahan accepted this revision.Jun 22 2015, 5:03 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jun 22 2015, 5:03 PM
Closed by commit rP831c18e6be3b: Remove weird "Differential Results Table" view (authored by epriestley, committed by epriestley). · Explain WhyJun 23 2015, 5:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
12 lines
1 line
src/
2 lines
applications/
differential/
view/
webroot/
rsrc/
css/
application/
differential/
js/
application/
differential/

Diff 32391

View Options

resources/celerity/map.php

Loading...
View Options

resources/celerity/packages.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/differential/view/DifferentialResultsTableView.php

Loading...
View Options

webroot/rsrc/css/application/differential/results-table.css

Loading...
View Options

webroot/rsrc/js/application/differential/behavior-show-field-details.js

Loading...
Phabricator · Built by Phacility