Page MenuHomePhabricator
Differential D13370

Hide repository from atom view if it hasn't been set
ClosedPublic
Actions

Authored by joshuaspence on Jun 21 2015, 12:04 AM.
Tags
None
Referenced Files
F14357866: D13370.diff
Fri, Dec 20, 7:12 AM
Unknown Object (File)
Fri, Dec 13, 6:54 AM
Unknown Object (File)
Thu, Dec 12, 4:10 AM
Unknown Object (File)
Wed, Dec 11, 7:32 PM
Unknown Object (File)
Tue, Dec 10, 8:08 AM
Unknown Object (File)
Sun, Dec 8, 12:20 AM
Unknown Object (File)
Sat, Dec 7, 5:07 PM
Unknown Object (File)
Fri, Dec 6, 2:13 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T8626: Diviner book is linked to an unknown object
Commits
Restricted Diffusion Commit
rPf9e838024c71: Hide repository from atom view if it hasn't been set
Summary

Fixes T8626. I guess that $this->getViewer()->renderHandle(null) renders as "Unknown Object", which is somewhat odd to me.

Test Plan

Viewed an atom from a book without a repository linked to it.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 6906
Build 6928: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 32368.Jun 21 2015, 12:04 AM
joshuaspence retitled this revision from to Hide repository from atom view if it hasn't been set.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T8626: Diviner book is linked to an unknown object.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 21 2015, 12:04 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
epriestley accepted this revision.Jun 21 2015, 12:16 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 21 2015, 12:16 AM
Closed by commit rPf9e838024c71: Hide repository from atom view if it hasn't been set (authored by joshuaspence, committed by joshuaspence). · Explain WhyJun 21 2015, 1:09 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
diviner/
controller/
4 lines

Diff 32368

View Options

src/applications/diviner/controller/DivinerAtomController.php

Loading...
Phabricator · Built by Phacility