Page MenuHomePhabricator
Differential D13349

Make owners typeahead mostly reasonable
ClosedPublic
Actions

Authored by epriestley on Jun 18 2015, 10:14 PM.
Tags
None
Referenced Files
F13085486: D13349.diff
Wed, Apr 24, 11:49 PM
Unknown Object (File)
Thu, Apr 11, 8:04 AM
Unknown Object (File)
Sun, Apr 7, 12:13 PM
Unknown Object (File)
Sun, Mar 31, 9:42 AM
Unknown Object (File)
Sun, Mar 31, 1:33 AM
Unknown Object (File)
Mar 24 2024, 2:42 AM
Unknown Object (File)
Mar 10 2024, 10:44 PM
Unknown Object (File)
Feb 16 2024, 4:13 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T8320: Bring Owners out of the dark ages
T8427: Make owners typeahead browsable so installs can have more than 100 packages
Commits
Restricted Diffusion Commit
rP1851ca2d71aa: Make owners typeahead mostly reasonable
Summary

Ref T8320. Fixes T8427. This is still a little funky because Owners has weird name rules, but should fix the bugs (unselectable packages) in T8427.

Test Plan

Browsed Owners typaheads, used various search functions.

Diff Detail

Repository
rP Phabricator
Branch
owners1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 6857
Build 6879: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 32298.Jun 18 2015, 10:14 PM
epriestley retitled this revision from to Make owners typeahead mostly reasonable.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added tasks: T8427: Make owners typeahead browsable so installs can have more than 100 packages, T8320: Bring Owners out of the dark ages.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 18 2015, 10:14 PM
btrahan accepted this revision.Jun 18 2015, 10:53 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jun 18 2015, 10:53 PM
Closed by commit rP1851ca2d71aa: Make owners typeahead mostly reasonable (authored by epriestley, committed by epriestley). · Explain WhyJun 19 2015, 12:16 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 32298

View Options

src/applications/owners/query/PhabricatorOwnersPackageQuery.php

Loading...
View Options

src/applications/owners/query/PhabricatorOwnersPackageSearchEngine.php

Loading...
View Options

src/applications/owners/typeahead/PhabricatorOwnersPackageDatasource.php

Loading...
Phabricator · Built by Phacility