Page MenuHomePhabricator
Differential D13334

Quoted text remarkup should be smart enough to know when to add a '>' and when to add '> '
ClosedPublic
Actions

Authored by lpriestley on Jun 18 2015, 12:47 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Feb 8, 12:01 PM
Unknown Object (File)
Sat, Feb 8, 12:00 PM
Unknown Object (File)
Sat, Feb 8, 12:00 PM
Unknown Object (File)
Sat, Feb 8, 11:59 AM
Unknown Object (File)
Sat, Feb 8, 11:59 AM
Unknown Object (File)
Feb 3 2025, 6:38 AM
Unknown Object (File)
Feb 2 2025, 11:30 PM
Unknown Object (File)
Feb 1 2025, 1:04 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T8565: Quote text button [”] in header bar of Remarkup text areas does not work for multiply nested quotes
Commits
Restricted Diffusion Commit
rP46a225c7b1cb: Quoted text remarkup should be smart enough to know when to add a '>' and…
Summary

Fixes T8565, Quoted text remarkup should be smart enough to know when to add a '>' and when to add '> '

Test Plan

Open an object with remarkup comments, add 'quote', select that text click the quote button in the remarkup menu, text should become '> quote'. Select and click again, text should become '>> quote'.

Diff Detail

Repository
rP Phabricator
Branch
remarkupquotedtext
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6834
Build 6856: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

lpriestley updated this revision to Diff 32264.Jun 18 2015, 12:47 AM
lpriestley retitled this revision from to Quoted text remarkup should be smart enough to know when to add a '>' and when to add '> '.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley added a task: T8565: Quote text button [”] in header bar of Remarkup text areas does not work for multiply nested quotes.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 18 2015, 12:47 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
epriestley accepted this revision.Jun 18 2015, 1:32 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 18 2015, 1:32 AM
epriestley added a comment.Jun 18 2015, 1:33 AM

Oh, do bin/celerity map too since you touched JS.

lpriestley updated this revision to Diff 32265.Jun 18 2015, 1:33 AM
lpriestley edited edge metadata.

celery map

Closed by commit rP46a225c7b1cb: Quoted text remarkup should be smart enough to know when to add a '>' and… (authored by lpriestley, committed by lpriestley). · Explain WhyJun 18 2015, 1:34 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
24 lines
webroot/
rsrc/
js/
core/
20 lines

Diff 32265

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/js/core/behavior-phabricator-remarkup-assist.js

Loading...
Phabricator · Built by Phacility